[pyjks] Fill in jks.bks and other modules, improved constructors#10815
Merged
srittau merged 8 commits intopython:mainfrom Oct 6, 2023
Merged
[pyjks] Fill in jks.bks and other modules, improved constructors#10815srittau merged 8 commits intopython:mainfrom
srittau merged 8 commits intopython:mainfrom
Conversation
Additionally 1 fix to `jks.PrivateKeyEntry.__init__`
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Ah thanks again, I forgot the |
Member
|
We should improve the stubtest error message there — that kind of thing comes up a lot, and stubtest could be clearer about what's gone wrong in this case! |
Member
Filed python/mypy#16210 to improve this! |
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
Oct 4, 2023
This comment has been minimized.
This comment has been minimized.
…s, timestamp, etc). * Added `| None` to constructor arguments that may be None * Added `@overload` constructors for encrypted and unencrypted usages * Replaced `= ...` with `= None` where appropriate * Added helpful comments to `__init__` constructors
intgr
changed the title
Contributor
Author
|
Pushed lots of changes:
I could split these back out and open separate PR if you'd prefer. |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally:
PrivateKeyEntry.__init__(encrypted=)argumentSecretKeyEntry.__init__(sealed_obj=)argument| Noneto constructor arguments that may be None= ...with= Nonewhere appropriate@overloadconstructors for encrypted and unencrypted usages__init__constructors