Closed
Conversation
Member
Author
|
Yeah, doesn't look like this helps |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Member
Author
|
It looks like we had:
For shard 4, it took 8 minutes for each run of mypy checking Whether or not we decide to revert #9433, that's quite interesting! Cc. @hauntsaninja. |
Collaborator
|
That is interesting. I took a closer look, should be a simple fix to improve perf on manticore. |
hauntsaninja
added a commit
to hauntsaninja/mypy
that referenced
this pull request
Jan 3, 2023
When checking manticore with `--check-untyped-defs`, this is a 4x total speedup from master, from ~320s to ~80s. I looked into this because of python/typeshed#9443 (comment)
hauntsaninja
added a commit
to python/mypy
that referenced
this pull request
Jan 3, 2023
When checking manticore with `--check-untyped-defs`, this is a 4x total speedup from master, from ~320s to ~80s (uncompiled). I looked into this because of python/typeshed#9443 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might help reduce the performance impact of #9433 on
mypy_primerCI runs.