Check for buffer overflow in prim_ops::et_copy_index() by lucylq · Pull Request #12697 · pytorch/executorch

lucylq · 2025-07-22T00:08:40Z

Stack from ghstack (oldest at bottom):

-> Check for buffer overflow in prim_ops::et_copy_index() #12697

^
Test on top of D78676341.

Differential Revision: D78701418

^ Test on top of D78676341. Differential Revision: [D78701418](https://our.internmc.facebook.com/intern/diff/D78701418/) [ghstack-poisoned]

pytorch-bot · 2025-07-22T00:08:43Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12697

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 3ce7f72 with merge base e4bc149 ():

NEW FAILURE - The following job has failed:

pull / test-eval_llama-mmlu-linux / linux-job (gh)
RuntimeError: Command docker exec -t a8e2d58209f6efcf048837006d5536276ba794357701b42ebed3e0e76a173a3c /exec failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-07-22T00:09:04Z

This pull request was exported from Phabricator. Differential Revision: D78701418

github-actions · 2025-07-22T00:09:39Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

^ Test on top of D78676341. Differential Revision: [D78701418](https://our.internmc.facebook.com/intern/diff/D78701418/) [ghstack-poisoned]

Pull Request resolved: #12697 ^ Test on top of D78676341. ghstack-source-id: 297836250 @exported-using-ghexport Differential Revision: [D78701418](https://our.internmc.facebook.com/intern/diff/D78701418/)

facebook-github-bot · 2025-07-22T19:27:27Z

This pull request was exported from Phabricator. Differential Revision: D78701418

^ Test on top of D78676341. Differential Revision: [D78701418](https://our.internmc.facebook.com/intern/diff/D78701418/) [ghstack-poisoned]

Pull Request resolved: #12697 ^ Test on top of D78676341. ghstack-source-id: 298161226 @exported-using-ghexport Differential Revision: [D78701418](https://our.internmc.facebook.com/intern/diff/D78701418/)

facebook-github-bot · 2025-07-23T22:43:57Z

This pull request was exported from Phabricator. Differential Revision: D78701418

lucylq · 2025-07-24T19:40:41Z

@pytorchbot cherry-pick --onto release/0.7 -c critical

Differential Revision: D78701418 Pull Request resolved: #12697 (cherry picked from commit ede8249)

pytorchbot · 2025-07-24T19:43:09Z

Cherry picking #12697

The cherry pick PR is at #12827 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

[v0.7.0] Release Tracker #11075 (comment)

Details for Dev Infra team

Raised by workflow job

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #12697 ^ Test on top of D78676341. Differential Revision: [D78701418](https://our.internmc.facebook.com/intern/diff/D78701418/) Co-authored-by: lucylq <lfq@meta.com>

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #12699 * #12698 * #12697 ^ Test on top of D78676341. Differential Revision: [D78703809](https://our.internmc.facebook.com/intern/diff/D78703809/) Co-authored-by: lucylq <lfq@meta.com>

Check for buffer overflow in prim_ops::et_copy_index()

20691f1

^ Test on top of D78676341. Differential Revision: [D78701418](https://our.internmc.facebook.com/intern/diff/D78701418/) [ghstack-poisoned]

lucylq requested review from manuelcandales and swolchok as code owners July 22, 2025 00:08

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 22, 2025

This was referenced Jul 22, 2025

Out-of-bounds accesses in operator execution #12698

Closed

Integer overflow in HierarchicalAllocator::get_offset_address() #12699

Merged

facebook-github-bot added the fb-exported label Jul 22, 2025

Update on "Check for buffer overflow in prim_ops::et_copy_index()"

59816a2

^ Test on top of D78676341. Differential Revision: [D78701418](https://our.internmc.facebook.com/intern/diff/D78701418/) [ghstack-poisoned]

Update on "Check for buffer overflow in prim_ops::et_copy_index()"

3ce7f72

^ Test on top of D78676341. Differential Revision: [D78701418](https://our.internmc.facebook.com/intern/diff/D78701418/) [ghstack-poisoned]

swolchok approved these changes Jul 23, 2025

View reviewed changes

facebook-github-bot merged commit ede8249 into gh/lucylq/94/base Jul 24, 2025
100 of 102 checks passed

facebook-github-bot deleted the gh/lucylq/94/head branch July 24, 2025 18:28

facebook-github-bot temporarily deployed to cherry-pick-bot July 24, 2025 18:28 — with GitHub Actions Inactive

pytorchbot mentioned this pull request Jul 24, 2025

Check for buffer overflow in prim_ops::et_copy_index() #12822

Merged

pytorchbot pushed a commit that referenced this pull request Jul 24, 2025

Check for buffer overflow in prim_ops::et_copy_index()

0a130f3

Differential Revision: D78701418 Pull Request resolved: #12697 (cherry picked from commit ede8249)

pytorchbot mentioned this pull request Jul 24, 2025

Check for buffer overflow in prim_ops::et_copy_index() #12827

Merged

This was referenced Jul 24, 2025

[v0.7.0] Release Tracker #11075

Closed

Integer overflow in HierarchicalAllocator::get_offset_address() #12828

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check for buffer overflow in prim_ops::et_copy_index()#12697

Check for buffer overflow in prim_ops::et_copy_index()#12697
facebook-github-bot merged 3 commits into
gh/lucylq/94/basefrom
gh/lucylq/94/head

lucylq commented Jul 22, 2025 •

edited

Loading

Uh oh!

pytorch-bot Bot commented Jul 22, 2025 •

edited

Loading

Uh oh!

facebook-github-bot commented Jul 22, 2025

Uh oh!

github-actions Bot commented Jul 22, 2025

Uh oh!

facebook-github-bot commented Jul 22, 2025

Uh oh!

facebook-github-bot commented Jul 23, 2025

Uh oh!

Uh oh!

lucylq commented Jul 24, 2025

Uh oh!

pytorchbot commented Jul 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

lucylq commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot Bot commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12697

❌ 1 New Failure

Uh oh!

facebook-github-bot commented Jul 22, 2025

Uh oh!

github-actions Bot commented Jul 22, 2025

This PR needs a release notes: label

Uh oh!

facebook-github-bot commented Jul 22, 2025

Uh oh!

facebook-github-bot commented Jul 23, 2025

Uh oh!

Uh oh!

lucylq commented Jul 24, 2025

Uh oh!

pytorchbot commented Jul 24, 2025

Cherry picking #12697

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lucylq commented Jul 22, 2025 •

edited

Loading

pytorch-bot Bot commented Jul 22, 2025 •

edited

Loading

This PR needs a `release notes:` label