[autotune] Decouple PrecompileFuture from BaseSearch via PrecompileContext#1925
Open
hinriksnaer wants to merge 3 commits intopytorch:mainfrom
Open
[autotune] Decouple PrecompileFuture from BaseSearch via PrecompileContext#1925hinriksnaer wants to merge 3 commits intopytorch:mainfrom
hinriksnaer wants to merge 3 commits intopytorch:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
This was referenced Apr 2, 2026
Closed
Replace the back-reference to the full BaseSearch object with a narrow 5-field PrecompileContext dataclass (settings, log, kernel, args, jobs). This makes PrecompileFuture's dependencies explicit and testable in isolation. This change is part of a larger effort to introduce a BenchmarkProvider abstraction that encapsulates the benchmarking pipeline. PrecompileFuture currently holds a reference to BaseSearch to access 5 fields — when the BenchmarkProvider owns precompilation, it needs to pass its own context into PrecompileFuture without involving the search object. PrecompileContext makes that possible.
hinriksnaer
force-pushed
the
precompile-context
branch
from
18b1021 to
5506ee0
Compare
fulvius31
reviewed
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groundwork for #1803
Replace the back-reference to the full BaseSearch object with a narrow 5-field PrecompileContext dataclass (settings, log, kernel, args, jobs). This makes PrecompileFuture's dependencies explicit and testable in isolation.
This change is part of a larger effort to introduce a BenchmarkProvider abstraction that encapsulates the benchmarking pipeline. PrecompileFuture currently holds a reference to BaseSearch to access 5 fields — when the BenchmarkProvider owns precompilation, it needs to pass its own context into PrecompileFuture without involving the search object. PrecompileContext makes that possible.