Raise error when autotune_with_torch_compile_fusion is set without torch_compile_fusion#1951
Open
Raise error when autotune_with_torch_compile_fusion is set without torch_compile_fusion#1951
Conversation
meta-cla
bot
added
the
CLA Signed
…rch_compile_fusion Previously, setting autotune_with_torch_compile_fusion=True without torch_compile_fusion=True was silently ignored. Now it raises FusionAutotuneRequiresTorchCompileFusion at Settings construction time.
yf225
force-pushed
the
willfeng/error-on-fusion-autotune-without-fusion
branch
from
30f0c1c to
37da98b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
autotune_with_torch_compile_fusion=Truewithouttorch_compile_fusion=Truewas silently ignored.FusionAutotuneRequiresTorchCompileFusionatSettingsconstruction time with a clear error message.Test plan
Settings(autotune_with_torch_compile_fusion=True)raises the errorSettings(autotune_with_torch_compile_fusion=True, torch_compile_fusion=True)works fine