Skip to content

Bugfix of param --logFCthreshold#106

Merged
WackerO merged 4 commits intoqbic-pipelines:devfrom
SusiJo:fixLog2threshold
Feb 22, 2022
Merged

Bugfix of param --logFCthreshold#106
WackerO merged 4 commits intoqbic-pipelines:devfrom
SusiJo:fixLog2threshold

Conversation

@SusiJo
Copy link
Copy Markdown
Collaborator

@SusiJo SusiJo commented Feb 18, 2022

Many thanks to contributing to qbic-pipelines!

This PR closes Issue #101 and adjusts filtering to work properly.

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/qbic-pipelines/rnadeseq/tree/master/.github/CONTRIBUTING.md

Copy link
Copy Markdown
Collaborator

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, thanks for the fix @SusiJo. However by default we don't wanna apply a threshold, as we want the full list of genes. We can discuss that with Stefan, but I think that is what we said in our last meeting.

Comment thread conf/test.config
@ggabernet
Copy link
Copy Markdown
Collaborator

Hi Susanne,

ah yes, for the test data it is ok to change it to 2, I thought in the review that that was the default value for all runs

@SusiJo
Copy link
Copy Markdown
Collaborator Author

SusiJo commented Feb 22, 2022

Hi Gisela,
no, I just set the threshold in the `test.config, so it was not hardcoded in the pipeline.

Copy link
Copy Markdown
Collaborator

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks good to me then!

@WackerO WackerO merged commit c390131 into qbic-pipelines:dev Feb 22, 2022
@SusiJo SusiJo deleted the fixLog2threshold branch May 30, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants