Bugfix of param --logFCthreshold#106
Merged
WackerO merged 4 commits intoqbic-pipelines:devfrom Feb 22, 2022
Merged
Conversation
ggabernet
reviewed
Feb 18, 2022
Collaborator
ggabernet
left a comment
There was a problem hiding this comment.
The changes look good to me, thanks for the fix @SusiJo. However by default we don't wanna apply a threshold, as we want the full list of genes. We can discuss that with Stefan, but I think that is what we said in our last meeting.
Collaborator
|
Hi Susanne, ah yes, for the test data it is ok to change it to |
Collaborator
Author
|
Hi Gisela, |
ggabernet
approved these changes
Feb 22, 2022
Collaborator
ggabernet
left a comment
There was a problem hiding this comment.
Great, looks good to me then!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thanks to contributing to qbic-pipelines!
This PR closes Issue #101 and adjusts filtering to work properly.
PR checklist
nextflow run . -profile test,docker).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: https://github.com/qbic-pipelines/rnadeseq/tree/master/.github/CONTRIBUTING.md