Skip to content

Template update#115

Merged
WackerO merged 15 commits intoqbic-pipelines:devfrom
WackerO:dev
Apr 29, 2022
Merged

Template update#115
WackerO merged 15 commits intoqbic-pipelines:devfrom
WackerO:dev

Conversation

@WackerO
Copy link
Copy Markdown
Contributor

@WackerO WackerO commented Mar 31, 2022

Many thanks to contributing to qbic-pipelines!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/qbic-pipelines/rnadeseq/tree/master/.github/CONTRIBUTING.md

Copy link
Copy Markdown
Collaborator

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @WackerO , I had some comments and corrections here, but otherwise looks good!

Comment thread .github/markdownlint.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread assets/email_template.html Outdated
Comment thread assets/email_template.html Outdated
Comment thread assets/email_template.html Outdated
Comment thread assets/multiqc_config.yml Outdated
Comment thread assets/multiqc_config.yml Outdated
Comment thread conf/base.config Outdated
Comment thread docs/usage.md Outdated
WackerO and others added 8 commits March 31, 2022 14:54
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
Copy link
Copy Markdown
Collaborator

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @WackerO , just the Editorconfig linting is failing now, so that would need to be fixed, but I'll approve the PR already!

@WackerO WackerO changed the title Dev Template update Apr 21, 2022
@WackerO WackerO merged commit 57fc7ac into qbic-pipelines:dev Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants