Skip to content

Updated doc, fixed relevel bug, added relevel to github tests#125

Merged
WackerO merged 4 commits intoqbic-pipelines:devfrom
WackerO:export
May 20, 2022
Merged

Updated doc, fixed relevel bug, added relevel to github tests#125
WackerO merged 4 commits intoqbic-pipelines:devfrom
WackerO:export

Conversation

@WackerO
Copy link
Copy Markdown
Contributor

@WackerO WackerO commented May 20, 2022

Many thanks to contributing to qbic-pipelines!

This PR fixes a relevel bug and adds test_relevel to the github checks. It also updates the doc to state that the --species param is unnecessary if skipping pathway analysis.

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/qbic-pipelines/rnadeseq/tree/master/.github/CONTRIBUTING.md

@WackerO WackerO requested a review from SusiJo May 20, 2022 09:23
Copy link
Copy Markdown
Collaborator

@SusiJo SusiJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WackerO LGTM 🚀 Just make sure the prettier tests pass

@WackerO WackerO requested a review from ggabernet May 20, 2022 11:25
Copy link
Copy Markdown
Collaborator

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well seen the bug!

@WackerO WackerO merged commit afc2fc6 into qbic-pipelines:dev May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants