Skip to content

Consider contrast files for boxplots (8)#164

Merged
WackerO merged 4 commits intoqbic-pipelines:devfrom
WackerO:boxplots
Nov 24, 2022
Merged

Consider contrast files for boxplots (8)#164
WackerO merged 4 commits intoqbic-pipelines:devfrom
WackerO:boxplots

Conversation

@WackerO
Copy link
Copy Markdown
Contributor

@WackerO WackerO commented Oct 6, 2022

This PR closes #89, boxplots are now only generated for those contrasts listed in contrast_list/matrix if these files are provided

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/rnadeseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

(will not create plots for contrasts that are not listed)
@WackerO WackerO requested a review from ggabernet October 6, 2022 06:31
@WackerO WackerO changed the title Consider contrast files for boxplots (9) Consider contrast files for boxplots (8) Oct 6, 2022
@WackerO WackerO marked this pull request as draft October 20, 2022 08:45
@WackerO
Copy link
Copy Markdown
Contributor Author

WackerO commented Nov 4, 2022

I'll rerun the pipeline before and after this change and share the resulting boxplots with you @ggabernet

@WackerO WackerO marked this pull request as ready for review November 9, 2022 09:34
@WackerO WackerO marked this pull request as draft November 9, 2022 10:02
@WackerO WackerO marked this pull request as ready for review November 9, 2022 13:55
Copy link
Copy Markdown
Collaborator

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@WackerO WackerO merged commit 4f9648a into qbic-pipelines:dev Nov 24, 2022
@WackerO WackerO deleted the boxplots branch November 24, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants