Changed skip_pathway_analysis to run_pathway_analysis (10)#169
Merged
WackerO merged 10 commits intoqbic-pipelines:devfrom Nov 29, 2022
Merged
Changed skip_pathway_analysis to run_pathway_analysis (10)#169WackerO merged 10 commits intoqbic-pipelines:devfrom
WackerO merged 10 commits intoqbic-pipelines:devfrom
Conversation
false i.e. PA is not run
well as star_rsem/salmon all test the run_pathway_analysis flag
linting error on github
ggabernet
approved these changes
Nov 29, 2022
Collaborator
ggabernet
left a comment
There was a problem hiding this comment.
Just some comments, otherwise LGTM
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameter is for clarity's sake now called run_pathway_analysis, default false, as BioPM has to add pathway analysis specifically to offers as well -->closes #168
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).