Switch dockerhub to ghcr by WackerO · Pull Request #203 · qbic-pipelines/rnadeseq

WackerO · 2023-03-17T09:07:02Z

This PR changes the container repo to ghcr

PR checklist

… ghcr

github-actions · 2023-03-17T09:08:40Z

`nf-core lint` overall result: Passed ✅ ⚠️

Posted for pipeline commit 5fb1b58

+| ✅ 123 tests passed       |+
#| ❔  27 tests were ignored |#
!| ❗  10 tests had warnings |!

Details

❗ Test warnings:

nextflow_config - Config manifest.version should end in dev: '2.1'
readme - README did not have a Nextflow minimum version badge.
readme - README did not have a Nextflow minimum version mentioned in Quick Start section.
pipeline_todos - TODO string in base.config: Check the defaults for all processes
pipeline_todos - TODO string in base.config: Customise requirements for specific processes.
pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release
pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline
pipeline_todos - TODO string in rnadeseq.nf: Add all file path parameters for the pipeline to the list below
schema_lint - Parameter input is not defined in the correct subschema (input_output_options)

❔ Tests ignored:

files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
files_exist - File is ignored: .github/workflows/awsfulltest.yml
files_exist - File is ignored: .github/workflows/awstest.yml
files_exist - File is ignored: .github/workflows/push_dockerhub.yml
files_exist - File is ignored: assets/multiqc_config.yaml
files_exist - File is ignored: assets/nf-core-qbic-pipelines/rnadeseq_logo_light.png
files_exist - File is ignored: bin/markdown_to_html.r
files_exist - File is ignored: conf/test_full.config
files_exist - File is ignored: docs/images/nf-core-qbic-pipelines/rnadeseq_logo_dark.png
files_exist - File is ignored: docs/images/nf-core-qbic-pipelines/rnadeseq_logo_light.png
files_exist - File is ignored: lib/WorkflowQbic-pipelines/rnadeseq.groovy
nextflow_config - Config variable ignored: manifest.name
nextflow_config - Config variable ignored: manifest.homePage
nextflow_config - Config variable ignored: params.input
files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/config.yml
files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/feature_request.yml
files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
files_unchanged - File ignored due to lint config: assets/email_template.html
files_unchanged - File ignored due to lint config: assets/email_template.txt
files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
files_unchanged - File ignored due to lint config: docs/README.md
files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml

✅ Tests passed:

files_exist - File found: .gitattributes
files_exist - File found: .gitignore
files_exist - File found: .nf-core.yml
files_exist - File found: .editorconfig
files_exist - File found: .prettierignore
files_exist - File found: .prettierrc.yml
files_exist - File found: CHANGELOG.md
files_exist - File found: CITATIONS.md
files_exist - File found: CODE_OF_CONDUCT.md
files_exist - File found: CODE_OF_CONDUCT.md
files_exist - File found: LICENSE or LICENSE.md or LICENCE or LICENCE.md
files_exist - File found: nextflow_schema.json
files_exist - File found: nextflow.config
files_exist - File found: README.md
files_exist - File found: .github/.dockstore.yml
files_exist - File found: .github/CONTRIBUTING.md
files_exist - File found: .github/ISSUE_TEMPLATE/bug_report.yml
files_exist - File found: .github/ISSUE_TEMPLATE/feature_request.yml
files_exist - File found: .github/PULL_REQUEST_TEMPLATE.md
files_exist - File found: .github/workflows/branch.yml
files_exist - File found: .github/workflows/ci.yml
files_exist - File found: .github/workflows/linting_comment.yml
files_exist - File found: .github/workflows/linting.yml
files_exist - File found: assets/email_template.html
files_exist - File found: assets/email_template.txt
files_exist - File found: assets/sendmail_template.txt
files_exist - File found: assets/nf-core-rnadeseq_logo_light.png
files_exist - File found: conf/modules.config
files_exist - File found: conf/test.config
files_exist - File found: docs/images/nf-core-rnadeseq_logo_light.png
files_exist - File found: docs/images/nf-core-rnadeseq_logo_dark.png
files_exist - File found: docs/output.md
files_exist - File found: docs/README.md
files_exist - File found: docs/README.md
files_exist - File found: docs/usage.md
files_exist - File found: lib/nfcore_external_java_deps.jar
files_exist - File found: lib/NfcoreSchema.groovy
files_exist - File found: lib/NfcoreTemplate.groovy
files_exist - File found: lib/Utils.groovy
files_exist - File found: lib/WorkflowMain.groovy
files_exist - File found: main.nf
files_exist - File found: assets/multiqc_config.yml
files_exist - File found: conf/base.config
files_exist - File found: conf/igenomes.config
files_exist - File found: lib/WorkflowRnadeseq.groovy
files_exist - File found: modules.json
files_exist - File found: pyproject.toml
files_exist - File not found check: Singularity
files_exist - File not found check: parameters.settings.json
files_exist - File not found check: .nf-core.yaml
files_exist - File not found check: conf/aws.config
files_exist - File not found check: .github/ISSUE_TEMPLATE/bug_report.md
files_exist - File not found check: .github/ISSUE_TEMPLATE/feature_request.md
files_exist - File not found check: docs/images/nf-core-rnadeseq_logo.png
files_exist - File not found check: .markdownlint.yml
files_exist - File not found check: .yamllint.yml
files_exist - File not found check: lib/Checks.groovy
files_exist - File not found check: lib/Completion.groovy
files_exist - File not found check: lib/Workflow.groovy
files_exist - File not found check: .travis.yml
nextflow_config - Config variable found: manifest.nextflowVersion
nextflow_config - Config variable found: manifest.description
nextflow_config - Config variable found: manifest.version
nextflow_config - Config variable found: timeline.enabled
nextflow_config - Config variable found: trace.enabled
nextflow_config - Config variable found: report.enabled
nextflow_config - Config variable found: dag.enabled
nextflow_config - Config variable found: process.cpus
nextflow_config - Config variable found: process.memory
nextflow_config - Config variable found: process.time
nextflow_config - Config variable found: params.outdir
nextflow_config - Config variable found: params.show_hidden_params
nextflow_config - Config variable found: params.schema_ignore_params
nextflow_config - Config variable found: manifest.mainScript
nextflow_config - Config variable found: timeline.file
nextflow_config - Config variable found: trace.file
nextflow_config - Config variable found: report.file
nextflow_config - Config variable found: dag.file
nextflow_config - Config variable (correctly) not found: params.nf_required_version
nextflow_config - Config variable (correctly) not found: params.container
nextflow_config - Config variable (correctly) not found: params.singleEnd
nextflow_config - Config variable (correctly) not found: params.igenomesIgnore
nextflow_config - Config variable (correctly) not found: params.name
nextflow_config - Config variable (correctly) not found: params.enable_conda
nextflow_config - Config timeline.enabled had correct value: true
nextflow_config - Config report.enabled had correct value: true
nextflow_config - Config trace.enabled had correct value: true
nextflow_config - Config dag.enabled had correct value: true
nextflow_config - Config dag.file ended with .html
nextflow_config - Config variable manifest.nextflowVersion started with >= or !>=
nextflow_config - Config params.custom_config_version is set to master
nextflow_config - Config params.custom_config_base is set to https://raw.githubusercontent.com/nf-core/configs/master
nextflow_config - Lines for loading custom profiles found
files_unchanged - .gitattributes matches the template
files_unchanged - .prettierrc.yml matches the template
files_unchanged - .github/.dockstore.yml matches the template
files_unchanged - .github/workflows/linting_comment.yml matches the template
files_unchanged - lib/nfcore_external_java_deps.jar matches the template
files_unchanged - lib/NfcoreSchema.groovy matches the template
files_unchanged - lib/NfcoreTemplate.groovy matches the template
actions_ci - '.github/workflows/ci.yml' is triggered on expected events
actions_ci - '.github/workflows/ci.yml' checks minimum NF version
actions_awstest - '.github/workflows/awstest.yml' is triggered correctly
actions_awsfulltest - .github/workflows/awsfulltest.yml is triggered correctly
actions_awsfulltest - .github/workflows/awsfulltest.yml does not use -profile test
pipeline_name_conventions - Name adheres to nf-core convention
template_strings - Did not find any Jinja template strings (131 files)
schema_lint - Schema lint passed
schema_lint - Schema title + description lint passed
schema_params - Schema matched params returned from nextflow config
actions_schema_validation - Workflow validation passed: linting_comment.yml
actions_schema_validation - Workflow validation passed: push_github_container_reg.yml
actions_schema_validation - Workflow validation passed: awsfulltest.yml
actions_schema_validation - Workflow validation passed: awstest.yml
actions_schema_validation - Workflow validation passed: fix-linting.yml
actions_schema_validation - Workflow validation passed: branch.yml
actions_schema_validation - Workflow validation passed: ci.yml
actions_schema_validation - Workflow validation passed: linting.yml
merge_markers - No merge markers found in pipeline files
modules_json - Only installed modules found in modules.json
multiqc_config - 'assets/multiqc_config.yml' follows the ordering scheme of the minimally required plugins.
multiqc_config - 'assets/multiqc_config.yml' contains 'export_plots: true'.
modules_structure - modules directory structure is correct 'modules/nf-core/TOOL/SUBTOOL'

Run details

nf-core/tools version 2.7.2
Run at 2023-04-03 06:57:02

WackerO · 2023-03-23T07:10:41Z

Question: Can I rename the push_dockerhub file or is the name used by some piece of code that I overlooked?

ggabernet · 2023-03-23T08:39:25Z

Hi Oskar, you can rename the GHA workflow, no problem

ggabernet · 2023-03-23T08:41:38Z

The PR looks good to me, however you also need to specify ghcr.io/qbicpipelines/rnadeseq:dev inside the modules that use this container

Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>

container in module

WackerO · 2023-03-23T09:26:44Z

The PR looks good to me, however you also need to specify ghcr.io/qbicpipelines/rnadeseq:dev inside the modules that use this container

Oops, completely forgot...Just changed that!

SusiJo · 2023-04-03T06:38:33Z

Please make sure the repo prefix to which you push the container is consistent.

SusiJo

LGTM!

WackerO added 3 commits March 17, 2023 09:27

updated dockerfile and git ci for the ghcr changes

ceaaf5b

updated push_dockerhub

69e9fce

Merge branch 'dev' of https://github.com/qbic-pipelines/rnadeseq into…

1c2d697

… ghcr

updated changelog

806517c

WackerO marked this pull request as ready for review March 20, 2023 07:23

ggabernet reviewed Mar 23, 2023

View reviewed changes

Comment thread Dockerfile Outdated

WackerO and others added 2 commits March 23, 2023 10:14

Update Dockerfile

43bcde9

Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>

renamed push_dockerhub.yml to push_github_container_reg.yml; changed

f9f6c4b

container in module

SusiJo reviewed Apr 3, 2023

View reviewed changes

Comment thread .github/workflows/ci.yml

SusiJo reviewed Apr 3, 2023

View reviewed changes

Comment thread .github/workflows/push_github_container_reg.yml Outdated

SusiJo reviewed Apr 3, 2023

View reviewed changes

Comment thread modules/local/report.nf

Fixed container name

5fb1b58

SusiJo approved these changes Apr 3, 2023

View reviewed changes

WackerO merged commit 1c3d7ab into qbic-pipelines:dev Apr 3, 2023

WackerO deleted the ghcr branch April 3, 2023 08:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch dockerhub to ghcr#203

Switch dockerhub to ghcr#203
WackerO merged 7 commits intoqbic-pipelines:devfrom
WackerO:ghcr

WackerO commented Mar 17, 2023 •

edited

Loading

Uh oh!

github-actions Bot commented Mar 17, 2023 •

edited

Loading

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

Uh oh!

WackerO commented Mar 23, 2023

Uh oh!

ggabernet commented Mar 23, 2023

Uh oh!

Uh oh!

ggabernet commented Mar 23, 2023

Uh oh!

WackerO commented Mar 23, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SusiJo commented Apr 3, 2023

Uh oh!

SusiJo left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

WackerO commented Mar 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist

Uh oh!

github-actions Bot commented Mar 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

nf-core lint overall result: Passed ✅ ⚠️

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

Uh oh!

WackerO commented Mar 23, 2023

Uh oh!

ggabernet commented Mar 23, 2023

Uh oh!

Uh oh!

ggabernet commented Mar 23, 2023

Uh oh!

WackerO commented Mar 23, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SusiJo commented Apr 3, 2023

Uh oh!

SusiJo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

WackerO commented Mar 17, 2023 •

edited

Loading

github-actions Bot commented Mar 17, 2023 •

edited

Loading

`nf-core lint` overall result: Passed ✅ ⚠️