Skip to content

Fix new multiqc#236

Merged
WackerO merged 2 commits intoqbic-pipelines:devfrom
WackerO:fix_new_mqc
Jun 4, 2024
Merged

Fix new multiqc#236
WackerO merged 2 commits intoqbic-pipelines:devfrom
WackerO:fix_new_mqc

Conversation

@WackerO
Copy link
Copy Markdown
Contributor

@WackerO WackerO commented May 23, 2024

Add logic to better check which multiqc version is provided (sometimes both the old and the new table file are present in the mqc).

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 23, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 006c695

+| ✅ 172 tests passed       |+
#| ❔  13 tests were ignored |#
!| ❗   2 tests had warnings |!
Details

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.
  • schema_lint - Parameter input is not defined in the correct subschema (input_output_options)

❔ Tests ignored:

  • files_exist - File is ignored: lib/nfcore_external_java_deps.jar
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • nextflow_config - Config default ignored: params.custom_config_base
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File ignored due to lint config: docs/README.md
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-05-28 13:33:02

@WackerO
Copy link
Copy Markdown
Contributor Author

WackerO commented May 23, 2024

Push changelog before merge

Copy link
Copy Markdown
Contributor

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WackerO WackerO merged commit 2ca778c into qbic-pipelines:dev Jun 4, 2024
@WackerO WackerO deleted the fix_new_mqc branch June 4, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants