Release 2.3 - This time for real by WackerO · Pull Request #244 · qbic-pipelines/rnadeseq

WackerO · 2024-06-17T10:33:51Z

Second release PR after I found a bug in the previous one

PR checklist

This comment contains a description of changes (with reason).
If you've fixed a bug or added code that should be tested, add tests!
If you've added a new tool - have you followed the pipeline conventions in the contribution docs
Make sure your code lints (nf-core lint).
Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
Usage Documentation in docs/usage.md is updated.
Output Documentation in docs/output.md is updated.
CHANGELOG.md is updated.
README.md is updated (including new tool citations and authors/contributors).

Fix report issue with missing logo

github-actions · 2024-06-17T10:34:04Z

This PR is against the `master` branch ❌

Do not close this PR
Click Edit and change the base to dev
This CI test will remain failed until you push a new commit

Hi @WackerO,

It looks like this pull-request is has been made against the qbic-pipelines/rnadeseq master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the qbic-pipelines/rnadeseq dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

github-actions · 2024-06-17T10:37:48Z

`nf-core lint` overall result: Passed ✅ ⚠️

Posted for pipeline commit 169e70e

+| ✅ 171 tests passed       |+
#| ❔  17 tests were ignored |#
!| ❗   3 tests had warnings |!

Details

❗ Test warnings:

nextflow_config - Config manifest.version should end in dev: 2.3
readme - README did not have a Nextflow minimum version badge.
schema_lint - Parameter input is not defined in the correct subschema (input_output_options)

❔ Tests ignored:

files_exist - File is ignored: lib/nfcore_external_java_deps.jar
nextflow_config - Config variable ignored: manifest.name
nextflow_config - Config variable ignored: manifest.homePage
nextflow_config - Config default ignored: params.report_file
nextflow_config - Config default ignored: params.references_file
nextflow_config - Config default ignored: params.css
nextflow_config - Config default ignored: params.logo
nextflow_config - Config default ignored: params.custom_config_base
files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
files_unchanged - File ignored due to lint config: assets/email_template.txt
files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
files_unchanged - File ignored due to lint config: docs/README.md
files_unchanged - File ignored due to lint config: .gitignore or .prettierignore

✅ Tests passed:

files_exist - File found: .gitattributes
files_exist - File found: .gitignore
files_exist - File found: .nf-core.yml
files_exist - File found: .editorconfig
files_exist - File found: .prettierignore
files_exist - File found: .prettierrc.yml
files_exist - File found: CHANGELOG.md
files_exist - File found: CITATIONS.md
files_exist - File found: CODE_OF_CONDUCT.md
files_exist - File found: LICENSE or LICENSE.md or LICENCE or LICENCE.md
files_exist - File found: nextflow_schema.json
files_exist - File found: nextflow.config
files_exist - File found: README.md
files_exist - File found: .github/.dockstore.yml
files_exist - File found: .github/CONTRIBUTING.md
files_exist - File found: .github/ISSUE_TEMPLATE/bug_report.yml
files_exist - File found: .github/ISSUE_TEMPLATE/config.yml
files_exist - File found: .github/ISSUE_TEMPLATE/feature_request.yml
files_exist - File found: .github/PULL_REQUEST_TEMPLATE.md
files_exist - File found: .github/workflows/branch.yml
files_exist - File found: .github/workflows/ci.yml
files_exist - File found: .github/workflows/linting_comment.yml
files_exist - File found: .github/workflows/linting.yml
files_exist - File found: assets/email_template.html
files_exist - File found: assets/email_template.txt
files_exist - File found: assets/sendmail_template.txt
files_exist - File found: assets/nf-core-rnadeseq_logo_light.png
files_exist - File found: conf/modules.config
files_exist - File found: conf/test.config
files_exist - File found: conf/test_full.config
files_exist - File found: docs/images/nf-core-rnadeseq_logo_light.png
files_exist - File found: docs/images/nf-core-rnadeseq_logo_dark.png
files_exist - File found: docs/output.md
files_exist - File found: docs/README.md
files_exist - File found: docs/README.md
files_exist - File found: docs/usage.md
files_exist - File found: main.nf
files_exist - File found: assets/multiqc_config.yml
files_exist - File found: conf/base.config
files_exist - File found: conf/igenomes.config
files_exist - File found: .github/workflows/awstest.yml
files_exist - File found: .github/workflows/awsfulltest.yml
files_exist - File found: modules.json
files_exist - File not found check: .github/ISSUE_TEMPLATE/bug_report.md
files_exist - File not found check: .github/ISSUE_TEMPLATE/feature_request.md
files_exist - File not found check: .github/workflows/push_dockerhub.yml
files_exist - File not found check: .markdownlint.yml
files_exist - File not found check: .nf-core.yaml
files_exist - File not found check: .yamllint.yml
files_exist - File not found check: bin/markdown_to_html.r
files_exist - File not found check: conf/aws.config
files_exist - File not found check: docs/images/nf-core-rnadeseq_logo.png
files_exist - File not found check: lib/Checks.groovy
files_exist - File not found check: lib/Completion.groovy
files_exist - File not found check: lib/NfcoreTemplate.groovy
files_exist - File not found check: lib/Utils.groovy
files_exist - File not found check: lib/Workflow.groovy
files_exist - File not found check: lib/WorkflowMain.groovy
files_exist - File not found check: lib/WorkflowRnadeseq.groovy
files_exist - File not found check: parameters.settings.json
files_exist - File not found check: pipeline_template.yml
files_exist - File not found check: Singularity
files_exist - File not found check: .travis.yml
nextflow_config - Config variable found: manifest.nextflowVersion
nextflow_config - Config variable found: manifest.description
nextflow_config - Config variable found: manifest.version
nextflow_config - Config variable found: timeline.enabled
nextflow_config - Config variable found: trace.enabled
nextflow_config - Config variable found: report.enabled
nextflow_config - Config variable found: dag.enabled
nextflow_config - Config variable found: process.cpus
nextflow_config - Config variable found: process.memory
nextflow_config - Config variable found: process.time
nextflow_config - Config variable found: params.outdir
nextflow_config - Config variable found: params.input
nextflow_config - Config variable found: params.validationShowHiddenParams
nextflow_config - Config variable found: params.validationSchemaIgnoreParams
nextflow_config - Config variable found: manifest.mainScript
nextflow_config - Config variable found: timeline.file
nextflow_config - Config variable found: trace.file
nextflow_config - Config variable found: report.file
nextflow_config - Config variable found: dag.file
nextflow_config - Config variable (correctly) not found: params.nf_required_version
nextflow_config - Config variable (correctly) not found: params.container
nextflow_config - Config variable (correctly) not found: params.singleEnd
nextflow_config - Config variable (correctly) not found: params.igenomesIgnore
nextflow_config - Config variable (correctly) not found: params.name
nextflow_config - Config variable (correctly) not found: params.enable_conda
nextflow_config - Config timeline.enabled had correct value: true
nextflow_config - Config report.enabled had correct value: true
nextflow_config - Config trace.enabled had correct value: true
nextflow_config - Config dag.enabled had correct value: true
nextflow_config - Config dag.file ended with .html
nextflow_config - Config variable manifest.nextflowVersion started with >= or !>=
nextflow_config - Config params.custom_config_version is set to master
nextflow_config - Config params.custom_config_base is set to https://raw.githubusercontent.com/nf-core/configs/master
nextflow_config - Lines for loading custom profiles found
nextflow_config - nextflow.config contains configuration profile test
nextflow_config - Config default value correct: params.input_type= featurecounts
nextflow_config - Config default value correct: params.contrast_matrix= DEFAULT
nextflow_config - Config default value correct: params.contrast_list= DEFAULT1
nextflow_config - Config default value correct: params.contrast_pairs= DEFAULT2
nextflow_config - Config default value correct: params.genelist= NO_FILE
nextflow_config - Config default value correct: params.relevel= NO_FILE2
nextflow_config - Config default value correct: params.logFC_threshold= 0
nextflow_config - Config default value correct: params.adj_pval_threshold= 0.05
nextflow_config - Config default value correct: params.norm_method= rlog
nextflow_config - Config default value correct: params.vst_genes_number= 1000
nextflow_config - Config default value correct: params.round_DE= -1
nextflow_config - Config default value correct: params.custom_gmt= NO_FILE3
nextflow_config - Config default value correct: params.set_background= true
nextflow_config - Config default value correct: params.custom_background= NO_FILE7
nextflow_config - Config default value correct: params.min_DEG_pathway= 1
nextflow_config - Config default value correct: params.heatmaps_cluster_rows= true
nextflow_config - Config default value correct: params.heatmaps_cluster_cols= false
nextflow_config - Config default value correct: params.multiqc= NO_FILE4
nextflow_config - Config default value correct: params.quote= NO_FILE5
nextflow_config - Config default value correct: params.software_versions= NO_FILE6
nextflow_config - Config default value correct: params.igenomes_base= s3://ngi-igenomes/igenomes
nextflow_config - Config default value correct: params.outdir= ./results
nextflow_config - Config default value correct: params.tracedir= ./results/pipeline_info
nextflow_config - Config default value correct: params.custom_config_version= master
nextflow_config - Config default value correct: params.max_cpus= 16
nextflow_config - Config default value correct: params.max_memory= 128.GB
nextflow_config - Config default value correct: params.max_time= 240.h
files_unchanged - .gitattributes matches the template
files_unchanged - .prettierrc.yml matches the template
files_unchanged - .github/.dockstore.yml matches the template
files_unchanged - .github/ISSUE_TEMPLATE/feature_request.yml matches the template
files_unchanged - .github/workflows/linting_comment.yml matches the template
files_unchanged - .github/workflows/linting.yml matches the template
files_unchanged - assets/email_template.html matches the template
actions_ci - '.github/workflows/ci.yml' is triggered on expected events
actions_ci - '.github/workflows/ci.yml' checks minimum NF version
actions_awstest - '.github/workflows/awstest.yml' is triggered correctly
actions_awsfulltest - .github/workflows/awsfulltest.yml is triggered correctly
actions_awsfulltest - .github/workflows/awsfulltest.yml does not use -profile test
readme - README Zenodo placeholder was replaced with DOI.
pipeline_todos - No TODO strings found
pipeline_name_conventions - Name adheres to nf-core convention
template_strings - Did not find any Jinja template strings (171 files)
schema_lint - Schema lint passed
schema_lint - Schema title + description lint passed
schema_params - Schema matched params returned from nextflow config
system_exit - No System.exit calls found
actions_schema_validation - Workflow validation passed: branch.yml
actions_schema_validation - Workflow validation passed: ci.yml
actions_schema_validation - Workflow validation passed: awsfulltest.yml
actions_schema_validation - Workflow validation passed: fix-linting.yml
actions_schema_validation - Workflow validation passed: linting.yml
actions_schema_validation - Workflow validation passed: download_pipeline.yml
actions_schema_validation - Workflow validation passed: clean-up.yml
actions_schema_validation - Workflow validation passed: awstest.yml
actions_schema_validation - Workflow validation passed: linting_comment.yml
actions_schema_validation - Workflow validation passed: push_github_container_reg.yml
merge_markers - No merge markers found in pipeline files
modules_json - Only installed modules found in modules.json
multiqc_config - assets/multiqc_config.yml found and not ignored.
multiqc_config - assets/multiqc_config.yml contains report_section_order
multiqc_config - assets/multiqc_config.yml contains export_plots
multiqc_config - assets/multiqc_config.yml contains report_comment
multiqc_config - assets/multiqc_config.yml follows the ordering scheme of the minimally required plugins.
multiqc_config - assets/multiqc_config.yml contains 'export_plots: true'.
modules_structure - modules directory structure is correct 'modules/nf-core/TOOL/SUBTOOL'
base_config - conf/base.config found and not ignored.
modules_config - conf/modules.config found and not ignored.
modules_config - REPORT found in conf/modules.config and Nextflow scripts.
modules_config - SAMPLESHEET_CHECK found in conf/modules.config and Nextflow scripts.
modules_config - CUSTOM_DUMPSOFTWAREVERSIONS found in conf/modules.config and Nextflow scripts.
nfcore_yml - Repository type in .nf-core.yml is valid: pipeline
nfcore_yml - nf-core version in .nf-core.yml is set to the latest version: 2.14.1

Run details

nf-core/tools version 2.14.1
Run at 2024-06-17 12:27:46

Co-authored-by: Sabrina Krakau <sabrinakrakau@gmail.com>

skrakau · 2024-06-17T12:27:51Z

Even if the PR does not contain a lot of changes, it would be helpful (and best-practice) to briefly describe what this PR is about, and what the previous bug was about.

LaurenceKuhl · 2024-06-17T12:28:32Z

                    "type": "string",
                    "default": "${projectDir}/assets/references.bibtex",
                    "description": "Reference bibtex file for the report, should not be changed."
+                },


why is it a variable if it shouldn't be changed?

There was apparently some nextflow change; now it seems the files in assets/ cannot be accessed by processes unless they are provided to the respective module as channels.

skrakau

Apart from the typo it looks good to me!

WackerO and others added 5 commits June 14, 2024 16:00

Fix report issue with missing logo

c338382

linting

8559abf

finally fixed logo; also re-added colorbar to sample metadata

b886173

Update changelog

32f08b6

Merge pull request #243 from WackerO/dev

b910b81

Fix report issue with missing logo

skrakau reviewed Jun 17, 2024

View reviewed changes

Comment thread CHANGELOG.md Outdated

Update CHANGELOG.md

169e70e

Co-authored-by: Sabrina Krakau <sabrinakrakau@gmail.com>

LaurenceKuhl reviewed Jun 17, 2024

View reviewed changes

LaurenceKuhl approved these changes Jun 17, 2024

View reviewed changes

skrakau approved these changes Jun 17, 2024

View reviewed changes

WackerO merged commit 163c7ee into master Jun 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 2.3 - This time for real#244

Release 2.3 - This time for real#244
WackerO merged 6 commits intomasterfrom
dev

WackerO commented Jun 17, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 17, 2024

Uh oh!

github-actions Bot commented Jun 17, 2024 •

edited

Loading

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

Uh oh!

Uh oh!

skrakau commented Jun 17, 2024

Uh oh!

LaurenceKuhl Jun 17, 2024

Uh oh!

WackerO Jun 17, 2024

Uh oh!

skrakau left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

WackerO commented Jun 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist

Uh oh!

github-actions Bot commented Jun 17, 2024

This PR is against the master branch ❌

Uh oh!

github-actions Bot commented Jun 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

nf-core lint overall result: Passed ✅ ⚠️

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

Uh oh!

Uh oh!

skrakau commented Jun 17, 2024

Uh oh!

LaurenceKuhl Jun 17, 2024

Choose a reason for hiding this comment

Uh oh!

WackerO Jun 17, 2024

Choose a reason for hiding this comment

Uh oh!

skrakau left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

WackerO commented Jun 17, 2024 •

edited

Loading

This PR is against the `master` branch ❌

github-actions Bot commented Jun 17, 2024 •

edited

Loading

`nf-core lint` overall result: Passed ✅ ⚠️