Skip to content

2 - Changed/removed some report texts#247

Merged
WackerO merged 2 commits intoqbic-pipelines:devfrom
WackerO:report_text
Jul 22, 2024
Merged

2 - Changed/removed some report texts#247
WackerO merged 2 commits intoqbic-pipelines:devfrom
WackerO:report_text

Conversation

@WackerO
Copy link
Copy Markdown
Contributor

@WackerO WackerO commented Jul 19, 2024

Changed the report text that shows when the gprofiler GMT file could not be downloaded, removed hard-coded comment about usage of gprofiler databases KEGG and REAC in the report

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

…not be downloaded, removed hard-coded comment about usage of gprofiler databases KEGG and REAC in the report
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 19, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 4f3c171

+| ✅ 172 tests passed       |+
#| ❔  17 tests were ignored |#
!| ❗   2 tests had warnings |!
Details

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.
  • schema_lint - Parameter input is not defined in the correct subschema (input_output_options)

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-07-22 09:18:13

@WackerO WackerO changed the title Changed/removed some report texts 2 - Changed/removed some report texts Jul 19, 2024
Copy link
Copy Markdown
Collaborator

@skrakau skrakau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WackerO WackerO merged commit 38257f0 into qbic-pipelines:dev Jul 22, 2024
@WackerO WackerO deleted the report_text branch July 22, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants