Skip to content

Fixed bug with github actions#252

Merged
WackerO merged 3 commits intoqbic-pipelines:devfrom
WackerO:dev
Nov 19, 2024
Merged

Fixed bug with github actions#252
WackerO merged 3 commits intoqbic-pipelines:devfrom
WackerO:dev

Conversation

@WackerO
Copy link
Copy Markdown
Contributor

@WackerO WackerO commented Nov 14, 2024

Updates actions/upload-artifact to v4 to fix a CI bug

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link
Copy Markdown
Contributor

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I assume the template isnt at 3.0.2 and the failing nf-core linting / nf-core (pull_request) is therefore to be ignored?

@WackerO
Copy link
Copy Markdown
Contributor Author

WackerO commented Nov 19, 2024

Hey Daniel, thanks for the review! Yes, the template is quite behind...

@WackerO WackerO merged commit d904f4b into qbic-pipelines:dev Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants