Fix remarks from #257 for release 2.5#258
Merged
WackerO merged 1 commit intoqbic-pipelines:devfrom Dec 13, 2024
Merged
Conversation
…_threshold, remove excessive logic of the param
|
I think the linting fails because of the nf-validation / nf-schema changes. That can either be addressed with a TEMPLATE update or we fix it manually by updating the subworkflows and switching to nf-schema. |
famosab
approved these changes
Dec 13, 2024
famosab
left a comment
There was a problem hiding this comment.
LGTM -> there is just the linting fail but maybe that does not need to be tackled in this PR.
Contributor
Author
|
The linting stuff is because the template is old :S I did not have time for a template update. Thanks Famke! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes remarks from #257 by removing excessive check of the pathway_adj_pval_threshold param, adding a default description and prettifying
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).