Skip to content

Fix remarks from #257 for release 2.5#258

Merged
WackerO merged 1 commit intoqbic-pipelines:devfrom
WackerO:prepare_release
Dec 13, 2024
Merged

Fix remarks from #257 for release 2.5#258
WackerO merged 1 commit intoqbic-pipelines:devfrom
WackerO:prepare_release

Conversation

@WackerO
Copy link
Copy Markdown
Contributor

@WackerO WackerO commented Dec 13, 2024

Fixes remarks from #257 by removing excessive check of the pathway_adj_pval_threshold param, adding a default description and prettifying

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

…_threshold, remove excessive logic of the param
@famosab
Copy link
Copy Markdown

famosab commented Dec 13, 2024

I think the linting fails because of the nf-validation / nf-schema changes. That can either be addressed with a TEMPLATE update or we fix it manually by updating the subworkflows and switching to nf-schema.

Copy link
Copy Markdown

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -> there is just the linting fail but maybe that does not need to be tackled in this PR.

@WackerO
Copy link
Copy Markdown
Contributor Author

WackerO commented Dec 13, 2024

The linting stuff is because the template is old :S I did not have time for a template update. Thanks Famke!

@WackerO WackerO merged commit 284a057 into qbic-pipelines:dev Dec 13, 2024
@WackerO WackerO deleted the prepare_release branch December 13, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants