added col "Launch Year/Last Time Buy" to compute default tdp only fro…#16
Closed
nadnein wants to merge 1 commit intoqbic-projects:mainfrom
nadnein:Nadja
Closed
added col "Launch Year/Last Time Buy" to compute default tdp only fro…#16nadnein wants to merge 1 commit intoqbic-projects:mainfrom nadnein:Nadja
nadnein wants to merge 1 commit intoqbic-projects:mainfrom
nadnein:Nadja
Conversation
…m specs where the year is >= current year - 10; updated tests; TDP table is now final
nadnein
changed the title
JosuaCarl
requested changes
Mar 27, 2025
| 'cores': ['Total Cores', '# of CPU Cores', 'cores'], | ||
| 'threads': ['cores', 'Total Cores', '# of CPU Cores', 'Total Threads', '# of Threads', 'threads'] | ||
| 'threads': ['cores', 'Total Cores', '# of CPU Cores', 'Total Threads', '# of Threads', 'threads'], | ||
| 'Launch Year/Last Time Buy': ['Launch Year/Last Time Buy'], |
Collaborator
There was a problem hiding this comment.
Add this only once you use it (special case)
| int currentYear = Year.now().getValue() | ||
|
|
||
| DataFrame specifications_filtered = specifications.rows({ row -> | ||
| def year = row.get("Launch Year/Last Time Buy") as Integer |
Collaborator
There was a problem hiding this comment.
Ah, so that's how you select certain rows based on a criterium
| setup: | ||
| DataFrame input = DataFrame | ||
| .foldByColumn("test_col", "tdp (W)") | ||
| .of("test_val_1", "test_val_2", "test_val_3", "test_val_4", "15-30", "15-30", "1.5/10", "2.3--5") |
Collaborator
There was a problem hiding this comment.
We should probably document this behaviour in the Readme (select first valid number).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…m specs where the year is >= current year - 10; updated tests; TDP table is now final