Skip to content

Handle Base64 size for the RPC2 enpoint#113

Merged
Xpirix merged 4 commits intoqgis:masterfrom
Xpirix:rpc_payload_too_large_error
Jun 4, 2025
Merged

Handle Base64 size for the RPC2 enpoint#113
Xpirix merged 4 commits intoqgis:masterfrom
Xpirix:rpc_payload_too_large_error

Conversation

@Xpirix
Copy link
Copy Markdown
Collaborator

@Xpirix Xpirix commented May 20, 2025

Additional fix for #109 #101 #93 according to #111 (comment)

Cc @Gustry @timlinux

Changes summary:

  • Set the 34MB limit for the RPC2 endpoint and keep the 25MB limit for others. [Outdated]
  • Add comments to explain the Base64 size increase for the RPC2 endpoint. [Outdated]

Update:

  • Keep the 25MB limit everywhere

@Gustry
Copy link
Copy Markdown
Contributor

Gustry commented May 20, 2025

Thanks a lot for these comments within the code, it will make these values easier to understand by another developer (and to be sure one value only will not be updated and not the others).

Side note, if RPC has some limitations with base64 string, why not having a POST request, with a ZIP file attached ? Would it be different ? It would be easy to implement in tools like QGIS-Plugin-CI.

@Xpirix
Copy link
Copy Markdown
Collaborator Author

Xpirix commented May 20, 2025

Side note, if RPC has some limitations with base64 string, why not having a POST request, with a ZIP file attached ? Would it be different ? It would be easy to implement in tools like QGIS-Plugin-CI.

That would be the perfect solution. So we will have the limit of 25MB everywhere without exception. It's also possible to upload a plugin with the normal endpoint using access token.

@Gustry
Copy link
Copy Markdown
Contributor

Gustry commented May 20, 2025

Ok cool, so +1 for me if it makes things easier. We can adapt QGIS-Plugin-CI afterwards.

@Xpirix
Copy link
Copy Markdown
Collaborator Author

Xpirix commented May 20, 2025

Great, I've made the changes to keep the max upload size of 25MB everywhere. Thank you so much for your inputs @Gustry . Please let me know if we should wait for the changes on the QGIS-Plugin-CI before merging this.

Copy link
Copy Markdown
Contributor

@Gustry Gustry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm not sure I could follow, is the POST request already done ?

We can talk about that in Sweden IRL ;-) (I'm on vacation these days, so not available)

Comment thread qgis-app/settings_docker.py Outdated
Co-authored-by: Étienne Trimaille <gustrimaille@yahoo.fr>
@Gustry
Copy link
Copy Markdown
Contributor

Gustry commented Jun 4, 2025

Thanks @Xpirix !
Yes, good to me.

The POST request, with a token was done in qgis/QGIS-Django#326

@Xpirix Xpirix merged commit 627b240 into qgis:master Jun 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants