Handle Base64 size for the RPC2 enpoint#113
Conversation
|
Thanks a lot for these comments within the code, it will make these values easier to understand by another developer (and to be sure one value only will not be updated and not the others). Side note, if RPC has some limitations with base64 string, why not having a POST request, with a ZIP file attached ? Would it be different ? It would be easy to implement in tools like QGIS-Plugin-CI. |
That would be the perfect solution. So we will have the limit of 25MB everywhere without exception. It's also possible to upload a plugin with the normal endpoint using access token. |
|
Ok cool, so +1 for me if it makes things easier. We can adapt QGIS-Plugin-CI afterwards. |
|
Great, I've made the changes to keep the max upload size of 25MB everywhere. Thank you so much for your inputs @Gustry . Please let me know if we should wait for the changes on the QGIS-Plugin-CI before merging this. |
Co-authored-by: Étienne Trimaille <gustrimaille@yahoo.fr>
|
Thanks @Xpirix ! The POST request, with a token was done in qgis/QGIS-Django#326 |
Additional fix for #109 #101 #93 according to #111 (comment)
Cc @Gustry @timlinux
Changes summary:
Update: