Remove supportsQt6 check from metadata.txt and specific QGIS 4.0 conditions#250
Remove supportsQt6 check from metadata.txt and specific QGIS 4.0 conditions#250Xpirix merged 1 commit intoqgis:masterfrom
Conversation
| pluginversion__min_qg_version__gte=f"{settings.CURRENT_QGIS_MAJOR_VERSION}.0", | ||
| pluginversion__supports_qt6=True, | ||
| deprecated=False, | ||
| pluginversion__max_qg_version__gte=f"{settings.NEW_QGIS_MAJOR_VERSION}.0", |
There was a problem hiding this comment.
I am really not sure, but does this translate <= 4.0 while we should have < 4.0 ?
There was a problem hiding this comment.
Yes @3nids , we are checking the plugin versions that have max_qg_version greater than or equal to 4.0.
However, could you please explain why we should have < 4.0?
There was a problem hiding this comment.
just trying to understand what it was doing, but this is really new and apparently too early :)
There was a problem hiding this comment.
Actually, this will bring us back to the original behaviour before we implemented the supportsQt6 metadata and tweaked conditions for QGIS 4.0. So on the QGIS 4 plugins list, we will have plugins that have explicitly set qgisMaxVersion to at least 4.0.
For example:
- Min QGIS Version 3.22 and Max QGIS Version 4.0 -> QGIS 4.0 and QGIS > 3.22 list
- Min QGIS Version 4.0 and Max QGIS Version 4.99 -> Only QGIS >= 4 to 4.99 list
- Min QGIS Version 3.22 and Max QGIS Version 3.99 -> Only QGIS 3.22 to QGIS 3.99 list
Is that what is expected @borysiasty? Perhaps I also misunderstood the requirements.
There was a problem hiding this comment.
Also, this specific change on the model.py file is only for the QGIS 4 Ready Plugins list at https://plugins.qgis.org/plugins/new_qgis_ready/, as we don't have a filter by QGIS version on the website.
There was a problem hiding this comment.
Yes, it's exactly how it worked before introduction of this tag.
|
Quite a few of plugins already adopted this flag https://github.com/search?q=supportsQt6&type=code 354 occurrences, but I know there is a LOT of of false positive with forks etc. Maybe raise a warning in the plugin validator if this flag is found explaining that this is deprecated ? |
|
There are 316 plugins which have used this flag, I think it's fair to explain that this tag "was used" but due to recent changes in QGIS 4.0 release, this flag is not used anymore and the new way should be explain. https://plugins.qgis.org/plugins/new_qgis_ready/ There are blog article etc explaining this flag I will add a note in the wiki https://github.com/qgis/QGIS/wiki/Plugin-migration-to-be-compatible-with-Qt5-and-Qt6 |
|
@Gustry: good point about explaining this change. I'm going to update the wiki: qgis/QGIS#65169 If you're aware of other places mentioning the old rules, feel free to add them to that ticket. |
|
Merging this now and will append any additional fixes later. |
|
Deployed just now @borysiasty . The XML lists can take up to 30 minutes to get updated. |
|
Thanks for merging and working on this. However, there were 316 plugins compatible QGIS 4 yesterday, now there are only 213 plugins compatible. It really brings confusion to users (mostly PyQGIS devs) why their plugin suddenly disappeared from the list, without any notice or explanation. I know it's not easy, but let's try to improve a little bit. Is-it possible to add a message on top of https://plugins.qgis.org/plugins/new_qgis_ready/ with a bar explaining "How to upgrade your plugin QGIS 4 ? Your plugin is not on this list ? PLease read the wiki page" ? (Checked on https://plugins.qgis.org/plugins/new_qgis_ready/) |
|
Hi @Gustry, Good catch regarding the need to better advertise the need to fix plugin metadata. Just to clarify: please note that it’s not that something suddenly stopped working. It actually never worked properly, and those 316 − 213 = 103 plugins were not truly available for download in QGIS 4! They did work in QGIS 4 if they had already been installed in QGIS 3, which was even more confusing: plugin authors could see their plugin installed, and the plugin webpage indicated that everything was fine. Only one detail suggested that something was wrong: the “(re)install” button in the plugin manager was grayed out, but that was easy to miss. So I suspect that the authors of the 213 fully compatible plugins simply noticed the grayed-out button and updated qgisMaximumVersion to 4.x. |
|
Thank you for the hard work on this but to be honest, I am now more confused than ever, although the answer is probably easy.
Am I reading it correctly? |
|
@kannes You’re absolutely right. By default, it’s simply assumed the plugin works from the |
|
Thanks @kannes for asking, I was also confused. |
|
Hi @Guts , yes. I think that's definitely the suggestion here. Please also see https://plugins.qgis.org/docs/migrate-qgis4. |
|
@Xpirix thanks. Maybe mention the pyqgis4-checker tooling? |
Could you please share more details, as I'm not familiar with it? So will create another issue for that. |
|
Sorry to bump this again, but I noticed that https://plugins.qgis.org/docs/migrate-qgis4 says:
This contradicts the list I posted above regarding QGIS4-exclusive plugins and that @borysiasty said was correct. Also it contradicts @Gustry text in qgis/QGIS#65169 (comment):
Sorry for not noticing it earlier and for abusing this issue for questions. Is it correct, that a QGIS4-exclusive plugin just needs the |
|
Thanks for raising this inconsistency. @Xpirix, it's just wording, isn't it? |
|
Thanks for raising this @kannes and @borysiasty. Yes, there are some mistakes in the docs. I have created an issue (#272 ) to fix them. |
Closes #249
See also qgis/QGIS#65146 and qgis/QGIS#65168
This will remove all supports related to the
supportsQt6field from the metadata and also remove all specific conditions related to QGIS 4.0 and revert back to the initial conditions.So all plugins version that have qgisMaximumVersion >= 4.0 will be considered as compatible with QGIS 4.0.
Cc @borysiasty @3nids