Quality: apply git hooks to whole codebase#285
Draft
Guts wants to merge 2 commits intoqgis:masterfrom
Draft
Conversation
Collaborator
|
Thanks for the suggestion @Guts .
I think some code formatting was already done before, so I think it should be fine. But sure, I will run it locally and submit another PR (maybe after #282 and #266 to avoid conflicts). Let's leave this open for now for me to remember. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows up #283. Looking at recent features regarding Python plugins quality checks (PEP8 compliance, security...), I wanted to make sure this project is following the same line.
Running
pre-commit run -ashows that git hooks are not applied to the whole codebase, leading to inconsistency and reducing maintenability.I put this PR in draft mode since it modifies a bunch of files and I'm not comfortable with getting authorship on these. I suggest that you run it on your side @Xpirix because you deserve it.
As said in #283, I recommend to connect this project to https://pre-commit.ci to make sure git hooks run for every PR independently of the local developer setup.