Skip to content

Add validation for backslashes in ZIP file names#287

Merged
Xpirix merged 3 commits intoqgis:masterfrom
Xpirix:backslashes_handling
Apr 8, 2026
Merged

Add validation for backslashes in ZIP file names#287
Xpirix merged 3 commits intoqgis:masterfrom
Xpirix:backslashes_handling

Conversation

@Xpirix
Copy link
Copy Markdown
Collaborator

@Xpirix Xpirix commented Mar 31, 2026

Closes #254

Cc @lnicola

image

@lnicola
Copy link
Copy Markdown

lnicola commented Apr 1, 2026

We could also check for drive letters (D:foo.py is actually a valid path on Windows), but I think it's unlikely we'll ever see one in a real archive.

@Xpirix
Copy link
Copy Markdown
Collaborator Author

Xpirix commented Apr 7, 2026

We could also check for drive letters (D:foo.py is actually a valid path on Windows), but I think it's unlikely we'll ever see one in a real archive.

Fixed it accordingly. Thanks @lnicola .

@Xpirix Xpirix merged commit 404aad0 into qgis:master Apr 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plugin ZIP validation doesn't cleanly reject \ as path separator

2 participants