Skip to content

IMP: allow column filtering in tabulate#69

Open
colinvwood wants to merge 2 commits intoqiime2:devfrom
colinvwood:tabulate-update
Open

IMP: allow column filtering in tabulate#69
colinvwood wants to merge 2 commits intoqiime2:devfrom
colinvwood:tabulate-update

Conversation

@colinvwood
Copy link
Copy Markdown

@colinvwood colinvwood commented Apr 30, 2026

Adds column-based filtering functionality. Also removes the table-hover style which previously shaded the currently hovered row, but seemed to be a) a darker shade in this version and b) a little buggy--I was seeing a row shaded even when the cursor was a little below that row.

Datatables 2 migration guide.

@github-project-automation github-project-automation Bot moved this to Backlog in 2026.7 🐐 Apr 30, 2026
@colinvwood colinvwood moved this from Backlog to Needs Review in 2026.7 🐐 Apr 30, 2026
@colinvwood colinvwood self-assigned this Apr 30, 2026
Comment thread q2_metadata/templates/tabulate/index.html
@Oddant1 Oddant1 self-requested a review April 30, 2026 23:07
Copy link
Copy Markdown
Member

@Oddant1 Oddant1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR failing CI 👎

I'm not seeing the issues you're describing with the hover. Can you show me when you get the chance?

Definitely a cool feature overall

Override DataTables striped row color to #F9F9F9 (was effectively #F2F2F2 from a 5% black box-shadow) and add a #E8F1F8 hover highlight that applies to all rows. Adds the table-hover class to enable the hover behavior.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs Review

Development

Successfully merging this pull request may close these issues.

4 participants