Conversation
|
No issue mentions found. Please mention an issue in the pull request description. Use GitHub automation to close the issue when a PR is merged |
There was a problem hiding this comment.
Pull request overview
This PR adds a comprehensive Claude command file for adding new linter plugins to the Qlty codebase. The command provides step-by-step instructions covering research, plugin structure creation, output format selection (SARIF, custom parser, or regex), parser implementation, testing, and reference examples.
Changes:
- Added
.claude/commands/add-plugin.mdwith detailed instructions for adding linter/formatter plugins - Includes complete templates for plugin.toml, README.md, test files, and fixtures
- Provides examples for runtime-based plugins (npm, pip, gem, Go) and binary releases
- Documents three output parsing options: SARIF, custom JSON parser, and regex parser
- Includes detailed Rust code templates for custom parsers and integration points
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| flake8 (`file:line:col: CODE message`): | ||
|
|
||
| ```toml | ||
| output_regex = "((?P<path>.*):(?P<line>-?\\d+):(?P<col>-?\\d+): (?P<code>\\S+) (?P<message>.+))\n" |
There was a problem hiding this comment.
The output_regex pattern ends with \n (escaped newline), but this may not be necessary or correct for all linters. The flake8 example in the actual codebase shows this pattern, but other regex-based parsers (like yamllint) don't include the trailing newline. The documentation should clarify when to include the newline in the regex pattern.
No description provided.