Skip to content

fix(check): skip exported config for formatters when workspace file exists #2711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marschattha wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(check): skip exported config for formatters when workspace file exists #2711

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5783fb
fix(check): skip exported config for formatters when workspace file e…
marschattha Mar 3, 2026
4b588af
test(check): add integration test for workspace config precedence ove…
marschattha Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions qlty-check/src/executor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,20 @@ impl Executor {

let mut loaded_config_files = vec![];

// load exported config paths before anything else
// load repository config files first so that workspace files take
// precedence over exported configs in the staging area
for config_file in &repository_config_files {
if let Err(err) = load_config_file_from_repository(
config_file,
&self.plan.workspace,
&self.plan.staging_area.destination_directory,
) {
error!("Failed to load config file from repository: {:?}", err);
}
}

// load exported config paths — these are skipped if the file already
// exists in the destination (e.g. from a workspace config file above)
for config_file in &exported_config_paths {
if self.plan.workspace.root != self.plan.staging_area.destination_directory {
// for formatters
Expand All @@ -337,16 +350,6 @@ impl Executor {
self.check_and_copy_configs_into_tool_install(&mut loaded_config_files)?;
self.plan_plugins_fetch(&mut loaded_config_files)?;

for config_file in &repository_config_files {
if let Err(err) = load_config_file_from_repository(
config_file,
&self.plan.workspace,
&self.plan.staging_area.destination_directory,
) {
error!("Failed to load config file from repository: {:?}", err);
}
}

for config_file in &config_file_names {
if self.plan.workspace.root != self.plan.staging_area.destination_directory {
// for formatters
Expand Down
Loading
⚡