[cpullvm] Generalize clang xfail generation to work with other llvm projects#188
Draft
jonathonpenix wants to merge 1 commit intoqualcomm:qualcomm-softwarefrom
Draft
[cpullvm] Generalize clang xfail generation to work with other llvm projects#188jonathonpenix wants to merge 1 commit intoqualcomm:qualcomm-softwarefrom
jonathonpenix wants to merge 1 commit intoqualcomm:qualcomm-softwarefrom
Conversation
…rojects This lets us handle other projects in LLVM (lldb is the main motivating force here) similar to what we can do for clang. Not all projects have an equivalent to CLANG_TEST_EXTRA_ARGS though so we use LLVM_LIT_ARGS instead to pass in the xfails list. But, we need to set LLVM_LIT_ARGS before we add LLVM as a subproject, so we can't just rely on the defaults like we do now. (See ex: how our compiler-rt xfails work.) I don't think this is a huge deal, but maybe it'll cause some surprises. Signed-off-by: Jonathon Penix <jpenix@qti.qualcomm.com>
jonathonpenix
force-pushed
the
llvm_xfail
branch
from
d921813 to
8fecaf1
Compare
Contributor
Author
|
Sorry, never mind this actually--we probably want something like this eventually, but this requires more work to decide how to mark dependencies between the xfails files and arbitrary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets us handle other projects in LLVM (lldb is the main motivating force
here) similar to what we can do for clang.
Not all projects have an equivalent to CLANG_TEST_EXTRA_ARGS though so we use
LLVM_LIT_ARGS instead to pass in the xfails list. But, we need to set
LLVM_LIT_ARGS before we add LLVM as a subproject, so we can't just rely on the
defaults like we do now. (See ex: how our compiler-rt xfails work.) I don't
think this is a huge deal, but maybe it'll cause some surprises.