Merged
Conversation
CorruptComputer
force-pushed
the
net10
branch
from
43b8cb0 to
84d5615
Compare
Contributor
Author
|
I just squashed those commits so the history would be a bit cleaner, not entirely sure what made the test fail though, and only for .NET 9. The changes here look correct to me on the diff and the tests are all passing locally, so I don't think I made an error with git. Maybe some thing similar to what #264 was trying to fix? @qmfrederik If you have a chance to review this, could you re-run the Action to see if that resolves it? |
Collaborator
|
LGTM. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for .NET 10.
I also checked the PR for .NET 9 (#257) and saw the linked issue, I missed updating libicu for .NET 9, updated it to include up to their latest released version libicu78. The newest being used on Ubuntu right now is libicu76, which makes sense why they'd be getting errors when the here newest being generated for DEBs before was libicu74. I only use the RPMs with this, so I had not encountered the issue myself when testing.
https://github.com/unicode-org/icu/releases
https://packages.ubuntu.com/search?keywords=libicu&searchon=names&suite=all§ion=all