Ruff formatting and fixes that are compatible with current checks#1817
Merged
mpharrigan merged 6 commits intoquantumlib:mainfrom Feb 24, 2026
Merged
Ruff formatting and fixes that are compatible with current checks#1817mpharrigan merged 6 commits intoquantumlib:mainfrom
mpharrigan merged 6 commits intoquantumlib:mainfrom
Conversation
mpharrigan
added
the
devops
Open
mpharrigan
force-pushed
the
2026-02/ruff-compatible
branch
from
9929eae to
335ec9f
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1807
In #1806 , we fixed a lot of things identified by ruff. This PR introduces the configuration and finishes the rest of them.
This PR includes formatting changes preferred by
ruff formatfor which unmodifiedcheck/format-incrementalis also happy with. The ruff formatter is mostly compatible withblack, please see https://docs.astral.sh/ruff/formatter/black/This PR disabled
flynt. I don't think this is a high-value automation, we can do it with future ruff checks if we want, and it kept trying to mangle an fstring in shell_tools that required python 3.12+ (and there's no simple way to disable it for that line)cc @fdmalone @mhucka
this also revealed https://github.com/quantumlib/Qualtran/pull/1810/changes#r2835413664 which I'll open an issue for if there isn't a simple resolution