Skip to content

Commit 53fbcc1

Browse files
committed
Revert "Merge pull request TeamNewPipe#13590 from TeamNewPipe/misc"
This reverts commit 8dc1315, reversing changes made to d927f44.
1 parent 8dc1315 commit 53fbcc1

4 files changed

Lines changed: 9 additions & 28 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,13 +55,13 @@ jobs:
5555
cache: 'gradle'
5656

5757
- name: Build debug APK and run jvm tests
58-
run: ./gradlew assembleContinuous lintContinuous testDebugUnitTest --stacktrace -DskipFormatKtlint
58+
run: ./gradlew assembleDebug lintDebug testDebugUnitTest --stacktrace -DskipFormatKtlint
5959

6060
- name: Upload APK
6161
uses: actions/upload-artifact@v7
6262
with:
6363
name: app
64-
path: app/build/outputs/apk/continuous/*.apk
64+
path: app/build/outputs/apk/debug/*.apk
6565

6666
test-android:
6767
runs-on: ubuntu-latest

app/build.gradle.kts

Lines changed: 7 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,6 @@ plugins {
2121
val gitWorkingBranch = providers.exec {
2222
commandLine("git", "rev-parse", "--abbrev-ref", "HEAD")
2323
}.standardOutput.asText.map { it.trim() }
24-
val defaultBranches = listOf("master", "dev")
25-
val workingBranch = gitWorkingBranch.getOrElse("")
26-
val normalizedWorkingBranch = workingBranch
27-
.replaceFirst("^[^A-Za-z]+".toRegex(), "")
28-
.replace("[^0-9A-Za-z]+".toRegex(), "")
2924

3025
kotlin {
3126
jvmToolchain(21)
@@ -68,7 +63,14 @@ configure<ApplicationExtension> {
6863
isDebuggable = true
6964

7065
// suffix the app id and the app name with git branch name
66+
val defaultBranches = listOf("master", "dev")
67+
val workingBranch = gitWorkingBranch.getOrElse("")
68+
val normalizedWorkingBranch = workingBranch
69+
.replaceFirst("^[^A-Za-z]+".toRegex(), "")
70+
.replace("[^0-9A-Za-z]+".toRegex(), "")
71+
7172
if (normalizedWorkingBranch.isEmpty() || workingBranch in defaultBranches) {
73+
// default values when branch name could not be determined or is master or dev
7274
applicationIdSuffix = ".debug"
7375
resValue("string", "app_name", "NewPipe Debug")
7476
} else {
@@ -89,21 +91,6 @@ configure<ApplicationExtension> {
8991
"proguard-rules.pro"
9092
)
9193
}
92-
93-
register("continuous") {
94-
initWith(getByName("release"))
95-
signingConfig = signingConfigs.getByName("debug")
96-
isDefault = true
97-
98-
// suffix the app id and the app name with git branch name
99-
if (normalizedWorkingBranch.isEmpty() || workingBranch in defaultBranches) {
100-
applicationIdSuffix = ".continuous"
101-
resValue("string", "app_name", "NewPipe Continuous")
102-
} else {
103-
applicationIdSuffix = ".continuous.$normalizedWorkingBranch"
104-
resValue("string", "app_name", "NewPipe $workingBranch")
105-
}
106-
}
10794
}
10895

10996
lint {

buildSrc/settings.gradle.kts

Lines changed: 0 additions & 5 deletions
This file was deleted.

settings.gradle.kts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
* SPDX-License-Identifier: GPL-3.0-or-later
44
*/
55
enableFeaturePreview("TYPESAFE_PROJECT_ACCESSORS")
6-
rootProject.name = "NewPipe"
76

87
pluginManagement {
98
repositories {

0 commit comments

Comments
 (0)