Skip to content

Misc changes for building#13590

Merged
TobiGr merged 5 commits into
devfrom
misc
Jun 12, 2026
Merged

Misc changes for building#13590
TobiGr merged 5 commits into
devfrom
misc

Conversation

@theimpulson

@theimpulson theimpulson commented Jun 9, 2026

Copy link
Copy Markdown
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing) ⚠️ Your PR must target the refactor branch
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Adds a new build type for Android / app module that inits from release but is signed by debug key to help debugging and testing optimizations issues such as with R8 or resources shrinker
  • Sets projects name to resolve type-safe accessor warnings

Fixes and closes TeamNewPipe/NewPipe-nightly#44

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

This would help to test and debug progaurd changes easily

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
@github-actions github-actions Bot added the size/small PRs with less than 50 changed lines label Jun 9, 2026
@TobiGr

TobiGr commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

I thinknwe should integrate the new build type into the CI

@theimpulson theimpulson force-pushed the misc branch 2 times, most recently from 9342f22 to 5f291b0 Compare June 9, 2026 06:24
@TobiGr

TobiGr commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

I think we should build both, a release/continous and a debug version, for PRs. @Stypox @AudricV what do you think?

@Stypox Stypox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, thanks!

@Stypox

Stypox commented Jun 10, 2026

Copy link
Copy Markdown
Member

I think we should build both, a release/continous and a debug version, for PRs. @Stypox @AudricV what do you think?

I'm not sure, does it really add information or would it only slow down the CI?

Comment thread app/build.gradle.kts
@TobiGr

TobiGr commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

I think we should build both, a release/continous and a debug version, for PRs. @Stypox @AudricV what do you think?

I'm not sure, does it really add information or would it only slow down the CI?

You are correct. So let's just use this one.

@TobiGr TobiGr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI does not find an APK to upload.

build-and-test-jvm
No files were found with the provided path: app/build/outputs/apk/debug/*.apk. No artifacts will be uploaded.

theimpulson and others added 3 commits June 12, 2026 11:54
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
We cannot enable optimizations by default in debug builds, so simply set our new variant
as the default

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <contact@aayush.io>
@TobiGr TobiGr merged commit 8dc1315 into dev Jun 12, 2026
5 checks passed
@theimpulson theimpulson deleted the misc branch June 12, 2026 05:39
r-i-s-u added a commit to r-i-s-u/NewPipe that referenced this pull request Jun 12, 2026
This reverts commit 8dc1315, reversing
changes made to d927f44.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nightly Builds Are Failing?

3 participants