Fix #13009, STOMP: default to exclusive queues except stream queues (backport #13016)#15809
Merged
michaelklishin merged 6 commits intov4.3.xfrom Mar 23, 2026
Merged
Fix #13009, STOMP: default to exclusive queues except stream queues (backport #13016)#15809michaelklishin merged 6 commits intov4.3.xfrom
michaelklishin merged 6 commits intov4.3.xfrom
Conversation
(cherry picked from commit aeb153c)
(cherry picked from commit eddacfe)
(cherry picked from commit 8aa7d40)
The STOMP plugin still relies on `amqp_client` (for now), which cannot use `rabbit_vhost`, so we extract a new DQT resolution function that takes the virtual host DQT as an argument. The STOMP plugin then resolves the DQT using `rabbit_vhost` and `rabbit_registry`, passes it to `get_queue_type/2` and decides on the properties based on the canonicalized type name (a module name). (cherry picked from commit d8702f3)
via `rabbit_vhost:default_queue_type/1`. (cherry picked from commit a27c5ae)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #13016 (finished and merged recently, even if the PR is originally from late 2024).
Proposed Changes
STOMP: default to exclusive queues except for quorum queues and streams.
Now that non-durable, non-exclusive queues are disabled by default, this
updates the STOMP plugin to use:
/queue/<name>: declares a durable, non-exclusive, non-auto-delete queue/topic/<name>(default): declares a transient, exclusive, auto-delete queue bound to the topic exchange/topic/<name>withdurable:trueandauto-delete:false: declares a durable, non-exclusive, non-auto-delete queue, allowing shared and resumable subscriptions/exchange/<name>/<routing-key>: declares a transient, exclusive, auto-delete queue bound to thenameexchange/temp-queue/<name>: declares a transient, exclusive, auto-delete queue/amq/queue/<name>and/reply-queue/<name>: nothing changes, these reference a pre-existing queueThis is a Breaking Change
For some STOMP destination types and clients that rely on all defaults, this is, at least technically, a breaking change.
However, so is the status quo: as of
4.3.0, non-durable, non-exclusive queues cannot be declared without opting out (a server reconfiguration), and that's exactly what the current STOMP plugin uses.