Conversation
... instead of using `export_all` [Why] The use of `export_all` brings no benefit but hides problems, like dead code or never executed tests. This is the case here: the `auto_delete` testcase executes the `delete` testcase code and this went unnoticed because of this `export_all`... This will be fixed in a subsequent commit. (cherry picked from commit f6c8cd4) (cherry picked from commit 500f1cd)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The wrapper was calling the
deletetestcase code, not the expectedauto_deleteone…This is an automatic backport of pull request #15816 done by Mergify.
This is an automatic backport of pull request #15817 done by Mergify.