Fix rabbit_khepri delete-related wrappers (backport #15845) (backport #15907)#15908
Merged
Fix rabbit_khepri delete-related wrappers (backport #15845) (backport #15907)#15908
rabbit_khepri delete-related wrappers (backport #15845) (backport #15907)#15908Conversation
[Why] This wrapper was calling `khepri_adv:delete_many()`, not `khepri_adv:delete()` as the name was suggesting. They are not the same function and have not the same behaviour. This led to a performance issue with the branch that replaces the "delete queue" transaction by a simple delete (#14902) that was related to this confusion. [How] The wrapper is renamed to reflect the Khepri API being called. While here, add a `rabbit_khepri:adv_delete()` wrapper that calls the similarily named Khepri API. (cherry picked from commit 0d3edce) (cherry picked from commit 77cdf87)
[Why] This wrapper was calling `khepri:delete_many()`, not `khepri:delete()` as the name was suggesting. They are not the same function and have not the same behaviour. I did not identified any performance problem, but this is a similar naming issue as the one fixed by the previous commit. [How] The wrapper is renamed to reflect the Khepri API being called. While here, add a `rabbit_khepri:delete()` wrapper that calls the similarily named Khepri API. (cherry picked from commit 560b45b) (cherry picked from commit 174648e)
dumbbell
force-pushed
the
mergify/bp/v4.2.x/pr-15907
branch
from
7192eb6 to
b12948e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
rabbit_khepri:delete()andrabbit_khepri:adv_delete()wrapper were callingkhepri:delete_many()andkhepri_adv:delete_many()respectively, notkhepri{,_adv}:delete()as the names were suggesting. They are not the same function and have not the same behaviour.This led to a performance issue with the branch that replaces the "delete queue" transaction by a simple delete (#14902) that was related to this confusion.
How
The wrappers are renamed to reflect the Khepri APIs being called.
While here, add
rabbit_khepri:delete()andrabbit_khepri:adv_delete()wrappers that call the similarily named Khepri APIs.This is an automatic backport of pull request #15845 done by Mergify.
This is an automatic backport of pull request #15907 done by Mergify.