Skip to content

HTTP API: Display static connection info when stats are disabled#15975

Merged
michaelklishin merged 3 commits intomainfrom
connection-info-disable-metrics-conn
Apr 10, 2026
Merged

HTTP API: Display static connection info when stats are disabled#15975
michaelklishin merged 3 commits intomainfrom
connection-info-disable-metrics-conn

Conversation

@dcorbacho
Copy link
Copy Markdown
Contributor

@dcorbacho dcorbacho commented Apr 9, 2026

The connections endpoint with stats disabled takes:
'api/connections' with 20k connections: < 1s

@dcorbacho dcorbacho force-pushed the connection-info-disable-metrics-conn branch from bd687ae to 4557464 Compare April 9, 2026 14:42
@dcorbacho dcorbacho requested a review from ansd April 9, 2026 14:44
@dcorbacho dcorbacho marked this pull request as ready for review April 9, 2026 14:44
@michaelklishin
Copy link
Copy Markdown
Collaborator

Fixed a flake triggered on this branch in #15983.

on `GET /connections/:name` when the metrics collector is disabled.

References #15975
when the metrics collector is disabled.

References  #15975.
@michaelklishin michaelklishin merged commit 2bd0094 into main Apr 10, 2026
188 checks passed
@michaelklishin michaelklishin deleted the connection-info-disable-metrics-conn branch April 10, 2026 01:45
mergify Bot pushed a commit that referenced this pull request Apr 10, 2026
on `GET /connections/:name` when the metrics collector is disabled.

References #15975

(cherry picked from commit 916a53c)
mergify Bot pushed a commit that referenced this pull request Apr 10, 2026
when the metrics collector is disabled.

References  #15975.

(cherry picked from commit a7dc791)
michaelklishin added a commit that referenced this pull request Apr 10, 2026
HTTP API: Display static connection info when stats are disabled (backport #15975)
mergify Bot pushed a commit that referenced this pull request Apr 10, 2026
on `GET /connections/:name` when the metrics collector is disabled.

References #15975

(cherry picked from commit 916a53c)
(cherry picked from commit 5721531)
mergify Bot pushed a commit that referenced this pull request Apr 10, 2026
when the metrics collector is disabled.

References  #15975.

(cherry picked from commit a7dc791)
(cherry picked from commit 475e0be)
michaelklishin added a commit that referenced this pull request Apr 10, 2026
HTTP API: Display static connection info when stats are disabled (backport #15975) (backport #15991)
michaelklishin added a commit that referenced this pull request Apr 10, 2026
This removes a fallback because the idea is to only
serve a static set of properties (e.g. the client-provided
connection name).
@michaelklishin
Copy link
Copy Markdown
Collaborator

Will revert and re-submit the original version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants