Trust store: respect user-provided fail_if_no_peer_cert values#16201
Merged
michaelklishin merged 1 commit intomainfrom Apr 22, 2026
Merged
Trust store: respect user-provided fail_if_no_peer_cert values#16201michaelklishin merged 1 commit intomainfrom
fail_if_no_peer_cert values#16201michaelklishin merged 1 commit intomainfrom
Conversation
Previously, `fail_if_no_peer_cert` was hardcoded in `required_options()` and always ended up on the left side of `lists:ukeymerge/3`, overriding any user-provided value. This broke environments that need `fail_if_no_peer_cert = false` for mixed authentication (e.g. EXTERNAL withh a fallback PLAIN). Now the option is only injected (defaulting to `true`) when the user has not set it, allowing user configuration to take effect. Closes #16199.
michaelklishin
added a commit
that referenced
this pull request
Apr 27, 2026
For `4.3.1`: Trust store: respect user-provided `fail_if_no_peer_cert` values (backport #16201)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
fail_if_no_peer_certwas hardcoded inrequired_options()and always ended up on the left side oflists:ukeymerge/3, overriding any user-provided value. This broke environments that needfail_if_no_peer_cert = falsefor mixed authentication (e.g. EXTERNAL withh a fallback PLAIN).Now the option is only injected (defaulting to
true) when the user has not set it, allowing user configuration to take effect.Closes #16199.