Refactor Direct Reply-to one more time#16253
Merged
michaelklishin merged 3 commits intomainfrom May 4, 2026
Merged
Conversation
kjnilsson
requested changes
Apr 29, 2026
Contributor
kjnilsson
left a comment
kjnilsson
left a comment
There was a problem hiding this comment.
just wondering if we need a new function for this.
There are no functional (user-observable) changes.
Conflicts: deps/rabbit/Makefile
Plus address cosmetic review feedback.
michaelklishin
added a commit
that referenced
this pull request
May 4, 2026
Refactor Direct Reply-to one more time (backport #16253)
michaelklishin
added a commit
that referenced
this pull request
May 4, 2026
ansd
reviewed
May 4, 2026
| %% such as <<"reply@1234567">>. Malformed input raises and is caught by | ||
| %% the surrounding try. | ||
| node_hash_from_binary(NodeBin) -> | ||
| [_Prefix, Suffix] = binary:split(NodeBin, <<"@">>), |
Member
There was a problem hiding this comment.
We could use a compiled pattern here as done in
rabbitmq-server/deps/rabbit/src/rabbit_volatile_queue.erl
Lines 369 to 378 in b8591ac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are no functional (user-observable) changes.
"TTB" in the tests is for "term to binary".