Apply the per-node connection_max limit to AMQP 1.0 connections (backport #16300)#16301
Merged
michaelklishin merged 1 commit intov4.3.xfrom May 4, 2026
Merged
Apply the per-node connection_max limit to AMQP 1.0 connections (backport #16300)#16301michaelklishin merged 1 commit intov4.3.xfrom
connection_max limit to AMQP 1.0 connections (backport #16300)#16301michaelklishin merged 1 commit intov4.3.xfrom
Conversation
Historically, the `connection_max` limit was only
enforced by the AMQP 0-9-1 reader,
even though its documented meaning
("the maximum allowed number of client connections per node")
implicitly covers connections of all core protocols.
AMQP 1.0 is a core protocol these days on par
with AMQP 0-9-1, so the same limit should
apply to it.
The change is node-local and mixed version cluster-safe:
the modified `v1` connection record is entirely local
and not persisted, and the "protocol hand-off" contract
between the AMQP 0-9-1 and AMQP 1.0 reader modules
is also entirely node-local.
References #16299
(cherry picked from commit 4cfe6ec)
michaelklishin
added a commit
that referenced
this pull request
May 4, 2026
michaelklishin
added a commit
that referenced
this pull request
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Historically, the
connection_maxlimit was onlyenforced by the AMQP 0-9-1 reader,
even though its documented meaning
("the maximum allowed number of client connections per node")
implicitly covers connections of all core protocols.
AMQP 1.0 is a core protocol these days on par
with AMQP 0-9-1, so the same limit should apply to it.
The change is node-local and mixed version cluster-safe: the modified
v1connection record is entirely local and not persisted, and the "protocol hand-off" contract between the AMQP 0-9-1 and AMQP 1.0 reader modules is also entirely node-local.Further Comments
References #16299
This is an automatic backport of pull request #16300 done by [Mergify](https://mergify.com).