Definition export: change user tags to a JSON array#2676
Merged
acogoluegnes merged 7 commits intomasterfrom Dec 15, 2020
Merged
Definition export: change user tags to a JSON array#2676acogoluegnes merged 7 commits intomasterfrom
acogoluegnes merged 7 commits intomasterfrom
Conversation
As they are no longer a comma-separated list in a string. References #2667
acogoluegnes
approved these changes
Dec 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This makes exported user definitions generate the
user.tagsproperty as an array of strings instead of a comma-separated list in a single string. This makes significantly more sense in JSON. This is also a breaking changeto a behavior that's some nine years old. In order to limit the effects of this, we support both formats when
importing user definitions.
This means that
Types of Changes
Checklist
CONTRIBUTING.mddocumentFurther Comments
HTTP API clients such as Hop, Rabbit Hole, and the Ruby one will have to be updated.
Closes #2667.