Skip to content

Refactor suites to shorten pipeline execution#9292

Merged
michaelklishin merged 4 commits intomainfrom
improve-selenium-pipeline
Sep 5, 2023
Merged

Refactor suites to shorten pipeline execution#9292
michaelklishin merged 4 commits intomainfrom
improve-selenium-pipeline

Conversation

@MarcialRosales
Copy link
Copy Markdown
Contributor

@MarcialRosales MarcialRosales commented Sep 5, 2023

Proposed Changes

  • Separate pure management ui suites from authnz ones. As the name indicates, the management ui suites runs management ui test cases. And the authnz suites run test cases against authn and authz backends and combinations of them. This last suite helped us spot some issues which had not been spotted by the respective auth-backends' tests .
  • Run management ui suite on every commit to main or release branches
  • Run management ui suite on every change done to rabbitmq_management plugin only on any PR

As a consequence, a commit to a PR should not trigger any selenium pipeline if the commit did not affect any file under deps/rabbitmq_management. There is a small risk that a change outside of the management ui breaks the management ui. Should this happened, the selenium pipeline on main, or branch releases, will spot it.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

- Separate pure management ui suites from authnz
- Run full management ui suite on every commit to main or
 release brances
 - Fun full management ui suite on every change done to
 rabbitmq_management plugin on any PR
@MarcialRosales MarcialRosales force-pushed the improve-selenium-pipeline branch from 913eab7 to 54ff327 Compare September 5, 2023 17:51
@MarcialRosales MarcialRosales marked this pull request as ready for review September 5, 2023 17:51
@michaelklishin michaelklishin merged commit 808112a into main Sep 5, 2023
@michaelklishin michaelklishin deleted the improve-selenium-pipeline branch September 5, 2023 20:50
michaelklishin added a commit that referenced this pull request Sep 5, 2023
Refactor suites to shorten pipeline execution (backport #9292)
michaelklishin added a commit that referenced this pull request Sep 5, 2023
Refactor suites to shorten pipeline execution (backport #9292) (backport #9305)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants