remove fail_if_no_peer_cert#1933
Merged
lukebakken merged 1 commit intorabbitmq:mainfrom May 24, 2024
Merged
Conversation
Remove fail_if_no_peer_cert from amqp_client options as it is no longer valid with Erlang 26 and will stop the connection from working
|
@womblep Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@womblep Thank you for signing the Contributor License Agreement! |
lukebakken
approved these changes
May 24, 2024
Collaborator
|
Thanks! |
Contributor
|
This is a new parameter check in Erlang 26's TLS implementation, as far as I can tell. In other words, it has gone unnoticed because very likley it's a valid combination of settings on Erlang 25. |
12 tasks
michaelklishin
added a commit
that referenced
this pull request
Jul 29, 2024
Contributor
|
Note: this was not backported to the 3.13.x version of the docs. Corrected in 2ac6c0f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove fail_if_no_peer_cert from amqp_client options as it is no longer valid with Erlang 26 and will stop the connection from working