Prevent FallbackScan from polluting exception cause#314
Merged
burke merged 1 commit intorails:masterfrom Aug 5, 2020
Merged
Conversation
ghost
added
the
|
The maintainer might just take this code as a proof-of-concept and make the changes themselves. That would obviate the CLA hoop-jumping and delays. |
aaronjensen
force-pushed
the
fix-error-cause-pollution
branch
from
7c5f386 to
29b77ee
Compare
Contributor
|
LGTM. We'll live without a test for this. |
|
Awesome ❤️ |
Contributor
Author
|
Thank you for the merge! If you have a free moment to cut a new gem release, I'd really appreciate it. Thank you. |
Contributor
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When debugging an issue with test-bench and bootsnap, I discovered that bootsnap pollutes error.cause by requiring the file naturally after a fallback scan within a rescue. This causes any error that is thrown within the required file to have a
#causedefined, which it should not. This improves output in test-bench when an error occurs and it may (I haven't tested this) improve output in other frameworks that inspect error.cause.I wasn't sure how to write a test for this because I didn't know how to trigger a fallback scan (I don't even really know what that is) and still load a real file that raises an exception. If you could give me a snippet for that I can add a test.
Thanks!