Inaccurate warning for ignoring vendored packages with subpath and version#324
Open
ron-shinall wants to merge 1 commit intorails:mainfrom
Open
Inaccurate warning for ignoring vendored packages with subpath and version#324ron-shinall wants to merge 1 commit intorails:mainfrom
ron-shinall wants to merge 1 commit intorails:mainfrom
Conversation
…rsion Remove unnecessary test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a warning that a couple of my vendored packages were being ignored as though there were unversioned:
For example, when executing
bin/importmap audit:This PR makes a change to use the
extract_base_package_name()method withinfind_unversioned_vendored_package()to make it consistent withpackages_with_versions()and eliminate the erroneous warning.I also created a new test to confirm that there is no longer a warning emitted.
@rafaelfranca please let me know if you prefer a different approach.