Updates bulma.min.css to fix css compile error when using legacy CSS bundlers sass-rails and sassc-rails #243
Merged
rosa merged 1 commit intorails:mainfrom Feb 7, 2025
Merged
Conversation
Member
|
Thank you! |
salmonsteakk
added a commit
to salmonsteakk/mission_control-jobs
that referenced
this pull request
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #237
When using legacy CSS bundlers sass-rails and sassc-rails the file "bulma.min.css" creates a CSS compile error:
"SassC::SyntaxError: Error: Invalid CSS after "...--s),var(--l));": expected "}", was "--00-l:var(--bulma-""This PR removes the valid, but problematic CSS code. The UI still works as expected, so the removal seems to be ok and the compile error is gone. Big thanks to @barrywoolgar who figured it all out!