Adds turbo stream to the discard button jobs#270
Closed
TimeTravelerFromNow wants to merge 1 commit intorails:mainfrom
TimeTravelerFromNow:main
Closed
Adds turbo stream to the discard button jobs#270TimeTravelerFromNow wants to merge 1 commit intorails:mainfrom TimeTravelerFromNow:main
TimeTravelerFromNow wants to merge 1 commit intorails:mainfrom
TimeTravelerFromNow:main
Conversation
Fixes issue #161 where the full refresh would clear the current job class filter, uses turbo to remove the table row instead of full refresh Co-authored-by: Yuri Bocharov <mail@yuribocharov.dev>
Member
|
Thanks a lot, @TimeTravelerFromNow! I like this approach a lot! Better than #272, great idea! If you're up for it, feel free to finish this with the fixes for the job count and the flash. If not, no worries, happy to help bringing this up to the finish line. |
Member
|
Wait, maybe, thinking about it again, #272 is better, but with some refinements. Hold on about this one 🙏 |
Member
|
Closing this one as #272 has been merged now 🥳 Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #161 where the full refresh would clear the current job class filter, uses turbo-stream true on the discard button to remove the table row without hard refresh.
Solution
This is a proof of concept using turbo streams, because we would like @rosa 's feedback on the approach.
An alternative solution is passing the current parameters into the discard button like so, but this has it's drawbacks as well.
Steps to test
Known issues
This can be solved by updating the count as well using the turbo_stream
.replacemethod within aturbo_stream.htmlIf we want to go forward with this approach, we should fix this known issue and add test coverage