Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion app/controllers/concerns/mission_control/jobs/job_filters.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module MissionControl::Jobs::JobFilters
included do
before_action :set_filters

helper_method :active_filters?
helper_method :active_filters?, :jobs_filter_param
end

private
Expand All @@ -20,6 +20,14 @@ def active_filters?
@job_filters.any?
end

def jobs_filter_param
if @job_filters&.any?
{ filter: @job_filters }
else
{}
end
end

def finished_at_range_params
range_start, range_end = params.dig(:filter, :finished_at_start), params.dig(:filter, :finished_at_end)
if range_start || range_end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ class MissionControl::Jobs::ApplicationController < MissionControl::Jobs.base_co
include MissionControl::Jobs::BasicAuthentication
include MissionControl::Jobs::ApplicationScoped, MissionControl::Jobs::NotFoundRedirections
include MissionControl::Jobs::AdapterFeatures
include MissionControl::Jobs::JobFilters

around_action :set_current_locale

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ def jobs_relation

def redirect_location
status = @job.status.presence_in(supported_job_statuses) || :failed
application_jobs_url(@application, status)
application_jobs_url(@application, status, **jobs_filter_param)
end
end
2 changes: 1 addition & 1 deletion app/controllers/mission_control/jobs/jobs_controller.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
class MissionControl::Jobs::JobsController < MissionControl::Jobs::ApplicationController
include MissionControl::Jobs::JobScoped, MissionControl::Jobs::JobFilters
include MissionControl::Jobs::JobScoped

skip_before_action :set_job, only: :index

Expand Down
2 changes: 1 addition & 1 deletion app/controllers/mission_control/jobs/retries_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ class MissionControl::Jobs::RetriesController < MissionControl::Jobs::Applicatio

def create
@job.retry
redirect_to application_jobs_url(@application, :failed), notice: "Retried job with id #{@job.job_id}"
redirect_to application_jobs_url(@application, :failed, **jobs_filter_param), notice: "Retried job with id #{@job.job_id}"
end

private
Expand Down
8 changes: 0 additions & 8 deletions app/helpers/mission_control/jobs/navigation_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,6 @@ def selected_server?(server)
MissionControl::Jobs::Current.server.name == server.name
end

def jobs_filter_param
if @job_filters&.any?
{ filter: @job_filters }
else
{}
end
end

def jobs_count_with_status(status)
count = ActiveJob.jobs.with_status(status).count
if count.infinite?
Expand Down
4 changes: 2 additions & 2 deletions app/views/mission_control/jobs/jobs/failed/_actions.html.erb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="buttons is-right">
<%= button_to "Discard", application_job_discard_path(@application, job.job_id), class: "button is-danger is-light mr-0",
<%= button_to "Discard", application_job_discard_path(@application, job.job_id, params: jobs_filter_param), class: "button is-danger is-light mr-0",
form: { data: { turbo_confirm: "This will delete the job and can't be undone. Are you sure?" } } %>
<%= button_to "Retry", application_job_retry_path(@application, job.job_id), class: "button is-warning is-light mr-0" %>
<%= button_to "Retry", application_job_retry_path(@application, job.job_id, params: jobs_filter_param), class: "button is-warning is-light mr-0" %>
</div>