Fix datetime shift in job filter for non-UTC timezones#278
Merged
rosa merged 4 commits intorails:mainfrom Aug 2, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Rails.application.config.time_zone is set to anything other than UTC, the datetime in the job filter shifts incorrectly each time it's edited.
For example, in my application where the timezone is set to Asia/Tokyo (+09:00), the time increases by 9 hours with every input.
time-zone-auto-shift.mov
Cause
The likely cause is how the datetime string is parsed.
The
form.datetime_fieldsubmits a datetime string in the%Y-%m-%dT%H:%Mformat, which is then parsed byDateTime.parse. However, regardless of the application's time zone setting, this method defaults to parsing the string as UTC when no time zone information is provided.Solution
This pull request fixes the issue by parsing the datetime string in the application's configured time zone.