Fix #duration when #scheduled_at is nil#289
Open
ric2b wants to merge 4 commits intorails:mainfrom
Open
Conversation
Author
|
Looks like this might not be necessary after SolidQueue 1.2.2 was released? It includes this fix: rails/solid_queue#637 Although I'm not sure if ActiveJob expects every job to have |
Member
|
I think this is a good idea regardless! Thank you. |
|
When will this be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a job is enqueued without
scheduled_atbeing set theapp/views/mission_control/jobs/jobs/show.html.erbtemplate breaks as thedurationcalculation currently expectsscheduled_atto have a value.Solution
Calculate the duration with
enqueued_atifscheduled_atisnil.Fixes #282