Use ActionController::Base as default base_controller_class#298
Open
brunoprietog wants to merge 1 commit intorails:mainfrom
Open
Use ActionController::Base as default base_controller_class#298brunoprietog wants to merge 1 commit intorails:mainfrom
brunoprietog wants to merge 1 commit intorails:mainfrom
Conversation
Prevents conflicts with custom authentication code defined in the host application's ApplicationController.
There was a problem hiding this comment.
Pull request overview
This PR changes the default base controller class for Mission Control Jobs from the host application's ApplicationController to Rails' ActionController::Base. This prevents authentication and authorization logic defined in the host application's ApplicationController from unintentionally affecting Mission Control's controllers, addressing issue #245.
Key Changes:
- Updates default
base_controller_classfrom"::ApplicationController"to"ActionController::Base"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents conflicts with custom authentication code defined in
the host application's
ApplicationController.Closes #245