belongs_to with custom foreign_key is breaking in 2.0.0.rc

[maokomioko]

Having a model with indirect association:
belongs_to :organization, primary_key: :org_number, foreign_key: :org_number

Belongs to association dropdowns return object's ID (as primary key) instead of customly specified key.

This looks like a regression from here:
be7d2f4#diff-3ccbdf28331673e0d29522ba324bddcfR81

Just to be sure I switched back to the earlier commit and dropdown values are filled with org_number as expected.

[mshibuya]

Belongs to association dropdowns return object's ID (as primary key) instead of customly specified key.

Yeah that's the intention of my fix. What are you trying to do? How does your schema look like and why do you need previous behavior?

[maokomioko]

Here is a more detailed look.

class EditorOrganizationRole < OrganizationRole
end

class OrganizationRole < ApplicationRecord
  belongs_to :organization, primary_key: :org_number, foreign_key: :org_number
end

class Organization < ApplicationRecord
end

create_table "organizations". force: :cascade do |t|
  t.string "org_number"
  # other fields
end

I'm trying to either create or modify EditorOrganizationRole.

A dropdown for organizations in production (pre-patch version) returns the org_number as a key:

The same dropdown in the current version (after-patch) returns an ID instead:

And that leads to the validation error, because editor_organization_role#org_number is getting organization's ID and lookup fails.

[mshibuya]

Sorry it was my fault, just pushed a fix 0e92ca4 in the master.
Thanks for reporting!