Add new item to the end of ordered multiselect instead of beginning#2167
Merged
mshibuya merged 2 commits intoAug 4, 2015
Merged
Conversation
Contributor
|
👍 |
Contributor
Author
|
@sferik Anything blocking this from getting merged? |
mshibuya
added a commit
that referenced
this pull request
Aug 4, 2015
Add new item to the end of ordered multiselect instead of beginning
Member
|
Merging in, thanks! |
Contributor
Author
|
@mshibuya Awesome, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using the filtering multiselect in a nested form with
orderable: true. For our use case, it is very important that elements are always in the right order.I noticed that when you create a new item, visually the new
<option>appears to be added as the last child of the<select>. But when the form is submitted to Rails, the new IDs have actually been inserted at the beginning instead of at the end.I finally tracked this down to a hidden
<select>which is the real one submitted via Ajax. Changingprependtoappendfixed the issue, causing new<option>s to be inserted at the end of the hidden<select>.I would be happy to write some specs, but I couldn't find any existing specs for the multiselect widget. Maybe I just need to be pointed to the right file or create a new one.