Don't ignore RailsAdmin controllers in NewRelic#2402
Merged
Conversation
Contributor
Author
|
@mshibuya can you please take a look at this one? I think this is a really simple change that helps people out a ton. |
mshibuya
added a commit
that referenced
this pull request
Oct 4, 2015
Don't ignore RailsAdmin controllers in NewRelic
Member
|
Merging in, thanks. |
Contributor
Author
|
Sure thing! https://github.com/sferik/rails_admin/wiki/Excluding-RailsAdmin-from-NewRelic, and linked from the main page too. |
Member
|
😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2318
First introduced in 33917af, the linked commit unilaterally removes the ability to measure RailsAdmin performance with NewRelic. This is a crazy thing to do out of the box, and incredibly surprising to find.
NewRelic offers many robust ways for users to ignore endpoints that they choose, from the method used here to https://docs.newrelic.com/docs/agents/ruby-agent/installation-configuration/ignoring-specific-transactions. There's no reason for RailsAdmin to be this prescriptive about this topic.
Personally, I am concerned about RailsAdmin performance in production, and want some insight into why our admin console times out so frequently.